fix(ci) update test to agree with new defaults #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set the admin API Service name for tests against the ingress chart. 5802d40 added a new default for gatewayDiscovery.generateAdminApiService. This setting is incompatible with specifying an admin Service name. The test was originally setting that name and failing, and the commit was merged to main despite.
4 tasks
pmalek
reviewed
Jul 24, 2023
pmalek
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set the admin API Service name for tests against the ingress chart.
5802d40 added a new default for gatewayDiscovery.generateAdminApiService. This setting is incompatible with specifying an admin Service name. The test was originally setting that name and failing, and the commit was merged to main despite in #840.