Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split sender and receiver config to not include rebalance_cb for receiver. #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

klimser
Copy link

@klimser klimser commented Oct 5, 2022

$conf->setRebalanceCb() called either for consumer and for producer.
It triggers warning from rdkafka CONFWARN:Configuration property rebalance_cb is a consumer property and will be ignored by this producer instance.
Config divided into producer and consumer parts, ->setRebalanceCb() called for consumer config only.

@andythorne
Copy link

This seems like a sensible change - please can we get this merged @KonstantinCodes?

@thePanz
Copy link

thePanz commented Feb 10, 2023

Thanks for fixing this @klimser !

There are other configurations that are applied to the producer, but are only available for the consumer, see:

rdkafka#producer-1| [thrd:app]: Configuration property group.id is a consumer property and will be ignored by this producer instance
rdkafka#producer-1| [thrd:app]: Configuration property enable.auto.offset.store is a consumer property and will be ignored by this producer instance
rdkafka#producer-1| [thrd:app]: Configuration property rebalance_cb is a consumer property and will be ignored by this producer instance

@klimser
Copy link
Author

klimser commented Feb 16, 2023

Thanks for fixing this @klimser !

There are other configurations that are applied to the producer, but are only available for the consumer, see:

rdkafka#producer-1| [thrd:app]: Configuration property group.id is a consumer property and will be ignored by this producer instance
rdkafka#producer-1| [thrd:app]: Configuration property enable.auto.offset.store is a consumer property and will be ignored by this producer instance
rdkafka#producer-1| [thrd:app]: Configuration property rebalance_cb is a consumer property and will be ignored by this producer instance

You are right, but you can control all that properties via $options except rebalance_cb that is set inside the method (look at changes of this Pull request).

@thePanz
Copy link

thePanz commented Feb 17, 2023

Thanks for fixing this @klimser !
There are other configurations that are applied to the producer, but are only available for the consumer, see:

rdkafka#producer-1| [thrd:app]: Configuration property group.id is a consumer property and will be ignored by this producer instance
rdkafka#producer-1| [thrd:app]: Configuration property enable.auto.offset.store is a consumer property and will be ignored by this producer instance
rdkafka#producer-1| [thrd:app]: Configuration property rebalance_cb is a consumer property and will be ignored by this producer instance

You are right, but you can control all that properties via $options except rebalance_cb that is set inside the method (look at changes of this Pull request).

True, but if I set $options['group.id'] it will be applied to both the consumer and receiver :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants