Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpanQuery serialization of a relation with an attribute #63

Open
margaretha opened this issue Nov 27, 2019 · 0 comments
Open

SpanQuery serialization of a relation with an attribute #63

margaretha opened this issue Nov 27, 2019 · 0 comments
Labels
enhancement

Comments

@margaretha
Copy link
Contributor

Serialization of a relation with an attribute should be updated. Currently it is serialized into a SpanWithAttribute. However, SpanAttribute would be sufficient because it describes the start and end positions of the element/relation it belongs to.

See de.ids_mannheim.korap.query.TestSpanRelationQueryJSON.testMatchBothRelationNodesWithAttribute()

The KoralQuery used in the test should also be simplified by removing layer and match in koral:span.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@margaretha