Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass options to Discover #117

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Pass options to Discover #117

wants to merge 3 commits into from

Commits on Dec 16, 2017

  1. Pass options to Discover 

    This enables passing options to harmonyhubjs-discover's Discover
constructor.

This closes KraigM#105.

For systems with multiple interfaces, using the default broadcast
address of 255.255.255.255 will not give consistent results. Instead,
you need to pass the appropriate broadcast address for the network
you're addressing, like 192.168.1.255 for the network 192.168.1.0/24.

This PR requires swissmanu/harmonyhubjs-discover#8 to be merged and
released.
    @stblassitude
    stblassitude committed Dec 16, 2017
    Configuration menu
    Copy the full SHA
    c0ca81d View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2017

  1. Roll back whitespace changes.

    @stblassitude
    stblassitude committed Dec 17, 2017
    Configuration menu
    Copy the full SHA
    6a98ecf View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2017

  1. Bump dependency to get new pingOptions for discover

    @stblassitude
    stblassitude committed Dec 21, 2017
    Configuration menu
    Copy the full SHA
    30426f2 View commit details
    Browse the repository at this point in the history