Add empty base optimization to allocators and containers

KredeGC · May 23, 2023 · 4c5e768 · 4c5e768
1 parent fd6238a
commit 4c5e768
Show file tree

Hide file tree

Showing 12 changed files with 32 additions and 14 deletions.
diff --git a/include/ktl/allocators/cascading.h b/include/ktl/allocators/cascading.h
@@ -3,6 +3,7 @@
 #include "../utility/aligned_malloc.h"
 #include "../utility/alignment.h"
 #include "../utility/assert.h"
+#include "../utility/empty_base.h"
 #include "../utility/meta.h"
 #include "cascading_fwd.h"
 #include "type_allocator.h"
@@ -35,7 +36,7 @@ namespace ktl
 	private:
 		struct node
 		{
-			Alloc Allocator;
+			KTL_EMPTY_BASE Alloc Allocator;
 			size_type Allocations = 0;
 			node* Next = nullptr;
 		};

diff --git a/include/ktl/allocators/fallback.h b/include/ktl/allocators/fallback.h
@@ -1,5 +1,6 @@
 #pragma once
 
+#include "../utility/empty_base.h"
 #include "../utility/meta.h"
 #include "fallback_fwd.h"
 #include "type_allocator.h"
@@ -188,7 +189,7 @@ namespace ktl
 #pragma endregion
 
 	private:
-		P m_Primary;
-		F m_Fallback;
+		KTL_EMPTY_BASE P m_Primary;
+		KTL_EMPTY_BASE F m_Fallback;
 	};
 }
diff --git a/include/ktl/allocators/freelist.h b/include/ktl/allocators/freelist.h
@@ -1,6 +1,7 @@
 #pragma once
 
 #include "../utility/assert.h"
+#include "../utility/empty_base.h"
 #include "../utility/meta.h"
 #include "freelist_fwd.h"
 #include "type_allocator.h"
@@ -224,7 +225,7 @@ namespace ktl
 		}
 
 	private:
-		Alloc m_Alloc;
+		KTL_EMPTY_BASE Alloc m_Alloc;
 		link* m_Free;
 	};
 }
diff --git a/include/ktl/allocators/overflow.h b/include/ktl/allocators/overflow.h
@@ -1,6 +1,7 @@
 #pragma once
 
 #include "../utility/assert.h"
+#include "../utility/empty_base.h"
 #include "../utility/meta.h"
 #include "overflow_fwd.h"
 #include "type_allocator.h"
@@ -261,7 +262,7 @@ namespace ktl
 
 	private:
 		Stream& m_Stream;
-		Alloc m_Alloc;
+		KTL_EMPTY_BASE Alloc m_Alloc;
 		int64_t m_Allocs;
 		int64_t m_Constructs;
 	};

diff --git a/include/ktl/allocators/segragator.h b/include/ktl/allocators/segragator.h
@@ -1,5 +1,6 @@
 #pragma once
 
+#include "../utility/empty_base.h"
 #include "../utility/meta.h"
 #include "segragator_fwd.h"
 #include "type_allocator.h"
@@ -182,7 +183,7 @@ namespace ktl
 #pragma endregion
 
 	private:
-		P m_Primary;
-		F m_Fallback;
+		KTL_EMPTY_BASE P m_Primary;
+		KTL_EMPTY_BASE F m_Fallback;
 	};
 }
diff --git a/include/ktl/allocators/shared.h b/include/ktl/allocators/shared.h
@@ -2,6 +2,7 @@
 
 #include "../utility/aligned_malloc.h"
 #include "../utility/alignment.h"
+#include "../utility/empty_base.h"
 #include "../utility/meta.h"
 #include "shared_fwd.h"
 
@@ -18,7 +19,7 @@ namespace ktl
 
 		struct block
 		{
-			Alloc Allocator;
+			KTL_EMPTY_BASE Alloc Allocator;
 			detail::get_size_type_t<Alloc> UseCount;
 
 			template<typename... Args,

diff --git a/include/ktl/allocators/threaded.h b/include/ktl/allocators/threaded.h
@@ -2,6 +2,7 @@
 
 #include "../utility/aligned_malloc.h"
 #include "../utility/alignment.h"
+#include "../utility/empty_base.h"
 #include "../utility/meta.h"
 #include "threaded_fwd.h"
 
@@ -20,7 +21,7 @@ namespace ktl
 
 		struct block
 		{
-			Alloc Allocator;
+			KTL_EMPTY_BASE Alloc Allocator;
 			std::atomic<detail::get_size_type_t<Alloc>> UseCount;
 			std::mutex Lock;
 

diff --git a/include/ktl/allocators/type_allocator.h b/include/ktl/allocators/type_allocator.h
@@ -1,5 +1,6 @@
 #pragma once
 
+#include "../utility/empty_base.h"
 #include "../utility/meta.h"
 
 #include "type_allocator_fwd.h"
@@ -158,7 +159,7 @@ namespace ktl
 		}
 
 	private:
-		Alloc m_Alloc;
+		KTL_EMPTY_BASE Alloc m_Alloc;
 	};
 
 	template<typename T, typename U, typename Alloc>

diff --git a/include/ktl/containers/binary_heap.h b/include/ktl/containers/binary_heap.h
@@ -1,6 +1,7 @@
 #pragma once
 
 #include "../utility/assert.h"
+#include "../utility/empty_base.h"
 #include "binary_heap_fwd.h"
 
 #include <cstddef>
@@ -458,8 +459,8 @@ namespace ktl
         }
 
     private:
-        Alloc m_Alloc;
-        Comp m_Comp;
+        KTL_EMPTY_BASE Alloc m_Alloc;
+        KTL_EMPTY_BASE Comp m_Comp;
 
         size_t m_Size;
         size_t m_Capacity;

diff --git a/include/ktl/containers/trivial_array.h b/include/ktl/containers/trivial_array.h
@@ -1,6 +1,7 @@
 #pragma once
 
 #include "../utility/assert.h"
+#include "../utility/empty_base.h"
 #include "trivial_array_fwd.h"
 
 #include <cstring>
@@ -302,7 +303,7 @@ namespace ktl
 		}
 
 	private:
-		Alloc m_Alloc;
+		KTL_EMPTY_BASE Alloc m_Alloc;
 		T* m_Begin;
 		T* m_End;
 	};

diff --git a/include/ktl/containers/trivial_vector.h b/include/ktl/containers/trivial_vector.h
@@ -1,6 +1,7 @@
 #pragma once
 
 #include "../utility/assert.h"
+#include "../utility/empty_base.h"
 #include "trivial_vector_fwd.h"
 
 #include <cstring>
@@ -458,7 +459,7 @@ namespace ktl
 		}
 
 	private:
-		Alloc m_Alloc;
+		KTL_EMPTY_BASE Alloc m_Alloc;
 		T* m_Begin;
 		T* m_End;
 		T* m_EndMax;

diff --git a/include/ktl/utility/empty_base.h b/include/ktl/utility/empty_base.h
@@ -0,0 +1,7 @@
+#pragma once
+
+#if defined(__has_cpp_attribute) && __has_cpp_attribute(no_unique_address)
+#define KTL_EMPTY_BASE [[no_unique_address]]
+#else // __has_cpp_attribute(no_unique_address)
+#define KTL_EMPTY_BASE
+#endif // __has_cpp_attribute(no_unique_address)