Memory leak fix (#18)

* Fixed memory leak #15 #16 * Update pom.xml Co-authored-by: Katsute <Katsute@users.noreply.github.com>
Ktt-Development · Apr 8, 2020 · 8cd7e2d · 8cd7e2d
1 parent 12e589d
commit 8cd7e2d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>com.kttdevelopment</groupId>
     <artifactId>simplehttpserver</artifactId>
-    <version>DEVELOPMENT</version>
+    <version>03.00.01</version>
     <packaging>jar</packaging>
 
     <dependencies>

diff --git a/src/main/java/com/kttdevelopment/simplehttpserver/SimpleHttpExchangeImpl.java b/src/main/java/com/kttdevelopment/simplehttpserver/SimpleHttpExchangeImpl.java
@@ -122,12 +122,10 @@ static SimpleHttpExchange createSimpleHttpExchange(final HttpExchange exchange){
 
             //
                 String OUT;
-                final InputStream IN = httpExchange.getRequestBody();
 
-                try(final Scanner scanner = new Scanner(IN,StandardCharsets.UTF_8)){
+                try(InputStream IN = httpExchange.getRequestBody(); final Scanner scanner = new Scanner(IN, StandardCharsets.UTF_8)){
                     OUT = scanner.useDelimiter("\\A").next();
-                    IN.close();
-                }catch(IOException | NoSuchElementException e){
+                }catch(final IOException | NoSuchElementException ignored){
                     OUT = null;
                 }
 
@@ -361,14 +359,17 @@ public void send(final byte[] response, final int responseCode, final boolean gz
                     exchange.getResponseHeaders().set("Content-Encoding","gzip");
                     exchange.getResponseHeaders().set("Connection","keep-alive");
                     sendResponseHeaders(responseCode, 0);
-                    GZIPOutputStream OUT = new GZIPOutputStream(exchange.getResponseBody());
-                    OUT.write(response);
-                    OUT.finish();
+                    try(GZIPOutputStream OUT = new GZIPOutputStream(exchange.getResponseBody())){
+                        OUT.write(response);
+                        OUT.finish();
+                        OUT.flush();
+                    }
                 }else{
                     sendResponseHeaders(responseCode,response.length);
-                    final OutputStream OUT = exchange.getResponseBody();
-                    OUT.write(response);
-                    OUT.flush();
+                    try(final OutputStream OUT = exchange.getResponseBody()){
+                        OUT.write(response);
+                        OUT.flush();
+                    }
                 }
             }