-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Fixing some broken links & strict builds #57
Conversation
/hold |
Some of these changes will also need to be cherry-picked to various release branches |
This'll remain on-hold for a while. Need new releases for various upstream components, and this change isn't really enough to justify new builds of all of the components here. Changes are landed on main for these, so when these changes get released over time, we should eventually be able to land this and turn strict builds on. Will use #56 to track status. |
Attempting to trigger netlify deploy preview. |
✅ Deploy Preview for graceful-kangaroo-3c9c10 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/unhold |
- run: mkdocs gh-deploy --force | ||
- run: mkdocs gh-deploy -s --force | ||
|
||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build on PR as well, with -s
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: david-martin, jasonmadigan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[docs] Fixing some broken links & strict builds
Ref: #56