Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fixing some broken links & strict builds #57

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

jasonmadigan
Copy link
Member

Ref: #56

mkdocs.yml Outdated Show resolved Hide resolved
@jasonmadigan
Copy link
Member Author

/hold

@jasonmadigan
Copy link
Member Author

Some of these changes will also need to be cherry-picked to various release branches

@jasonmadigan
Copy link
Member Author

This'll remain on-hold for a while. Need new releases for various upstream components, and this change isn't really enough to justify new builds of all of the components here. Changes are landed on main for these, so when these changes get released over time, we should eventually be able to land this and turn strict builds on.

Will use #56 to track status.

@jasonmadigan jasonmadigan changed the title [docs] Fixing some broken links [docs] Fixing some broken links & strict builds Feb 26, 2024
@david-martin
Copy link
Contributor

Attempting to trigger netlify deploy preview.
Closing and reopening PR

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for graceful-kangaroo-3c9c10 ready!

Name Link
🔨 Latest commit 4f7cbea
🔍 Latest deploy log https://app.netlify.com/sites/graceful-kangaroo-3c9c10/deploys/65f1af2398a9a10008f592ca
😎 Deploy Preview https://deploy-preview-57--graceful-kangaroo-3c9c10.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jasonmadigan
Copy link
Member Author

/unhold

- run: mkdocs gh-deploy --force
- run: mkdocs gh-deploy -s --force

build:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build on PR as well, with -s

@david-martin
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, jasonmadigan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [david-martin,jasonmadigan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 147264b into Kuadrant:main Mar 14, 2024
8 checks passed
jasonmadigan pushed a commit that referenced this pull request Mar 14, 2024
[docs] Fixing some broken links & strict builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants