Install sail-operator 0.1.0 #944
Conversation
|
I have tested on top of RLP from #893 and can see things working as expected. |
| # Supported values for sail-operator v0.1.0 are [v1.22.4,v1.23.0] | ||
| version: v1.23.0 |
There was a problem hiding this comment.
Note that whilst the supported versions listed here are the ones permitted by the CRD, the operator fails to configure the supported profile when set to v1.22.4 so in reality there's only the option of v1.23.0
There was a problem hiding this comment.
What version of GWAPI does that align with?
There was a problem hiding this comment.
I believe v1.23 is still GWAPI v1.1 and istio v1.24 will support GWAPI v1.2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
==========================================
- Coverage 81.49% 79.47% -2.02%
==========================================
Files 102 115 +13
Lines 7177 9605 +2428
==========================================
+ Hits 5849 7634 +1785
- Misses 898 1567 +669
+ Partials 430 404 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
eguzki
added
kind/enhancement
Add back fail-fast removal Signed-off-by: Adam Cattermole <acatterm@redhat.com>
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
adam-cattermole
force-pushed
the
install-sail-tp
branch
from
569f088
to
e5282c0
Compare
Additionally, istio default intallation tool in dev environments now it is Sail Operator Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
|
changes look good. I will verify it here locally also before approving |
|
I've tested this locally on top of the changes from #952 and the auth side of things is working |
|
@adam-cattermole is there anything that needs to be done with the quick start? Still haven't got to try this out yet have a backlog of stuff at the moment. Happy to approve though as you seem to have done a fair bit of validation here |
|
No worries, I'll have a go with the quickstart and report back, but either way I think I'll wait on merge until #952 is in |
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
adam-cattermole
force-pushed
the
install-sail-tp
branch
2 times, most recently
from
1594804
to
5ed7c49
Compare
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
adam-cattermole
force-pushed
the
install-sail-tp
branch
from
5ed7c49
to
7ff6599
Compare
|
@maleck13 Made changes for the quickstart - default is now sail and there was a couple changes to install this new version, including dependence on helm installed. I've got a PR to update the single cluster install guide here Kuadrant/docs.kuadrant.io#144 |
|
Can test it with: export KUADRANT_REF=install-sail-tp
curl "https://raw.githubusercontent.com/kuadrant/kuadrant-operator/${KUADRANT_REF}/hack/quickstart-setup.sh" | bash |
Signed-off-by: Adam Cattermole <acatterm@redhat.com>
adam-cattermole
force-pushed
the
install-sail-tp
branch
from
1f38867
to
8fea3a4
Compare
|
awsome will try this now |
* Re-enable sail integration test Add back fail-fast removal Signed-off-by: Adam Cattermole <acatterm@redhat.com> * Install sail-operator v0.1.0 Signed-off-by: Adam Cattermole <acatterm@redhat.com> * Istio installed using Sail operator added to integration tests (#954) Additionally, istio default intallation tool in dev environments now it is Sail Operator Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com> * Use sail as default for quickstart Signed-off-by: Adam Cattermole <acatterm@redhat.com> * Update quickstart sail installation Signed-off-by: Adam Cattermole <acatterm@redhat.com> * Add helm to development doc Signed-off-by: Adam Cattermole <acatterm@redhat.com> --------- Signed-off-by: Adam Cattermole <acatterm@redhat.com> Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com> Co-authored-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
Installs sail-operator using helm from istio-ecosystem/sail-operator@0.1.0 and re-enables integration tests.
Requires #893, #952
Continues #696
Closes #401