Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Futures margin types refactor / cleanup and perps v3 prep #2571

Merged
merged 58 commits into from
Aug 2, 2023

Conversation

avclarke
Copy link
Contributor

@avclarke avclarke commented Jul 7, 2023

Description

Initial perps v3 preparations

  • Create a perps v3 service on the sdk
  • Implement core v3 flows into existing UI
  • Refactor the app support perps v3 (cross margin) alongside perps v2 (smart margin)

@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Aug 2, 2023 8:55pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview Aug 2, 2023 8:55pm

@platschi platschi self-requested a review July 7, 2023 13:53
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #2571 (f443831) into dev (bfc59bd) will increase coverage by 1.44%.
Report is 28 commits behind head on dev.
The diff coverage is 52.40%.

@@            Coverage Diff             @@
##              dev    #2571      +/-   ##
==========================================
+ Coverage   51.27%   52.72%   +1.44%     
==========================================
  Files         382      392      +10     
  Lines       11540    12401     +861     
  Branches     2757     2843      +86     
==========================================
+ Hits         5917     6538     +621     
- Misses       5400     5629     +229     
- Partials      223      234      +11     
Files Changed Coverage Δ
...omponents/Currency/CurrencyPrice/CurrencyPrice.tsx 52.63% <ø> (ø)
packages/app/src/components/TVChart/DataFeed.ts 21.79% <ø> (+3.04%) ⬆️
packages/app/src/constants/links.ts 66.66% <ø> (ø)
...es/app/src/sections/futures/MarketDetails/utils.ts 100.00% <ø> (ø)
...app/src/sections/futures/ShareModal/ShareModal.tsx 76.19% <ø> (ø)
...ions/futures/SmartMarginOnboard/SmartMarginFAQ.tsx 50.00% <ø> (ø)
...sections/futures/Trade/MarketsDropdownSelector.tsx 89.65% <0.00%> (ø)
...ions/futures/TradingHistory/TradesHistoryTable.tsx 45.67% <0.00%> (-0.58%) ⬇️
...p/src/sections/shared/Layout/HomeLayout/Banner.tsx 43.18% <0.00%> (+3.59%) ⬆️
packages/app/src/state/exchange/actions.ts 13.06% <0.00%> (ø)
... and 109 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

* Copy changes over

* Add docgen command

* More docs

* Even more docs

* Start generating docs

* MD

* Fix formatting

* More docs

* Prices docs init

* Synth service docs

* Consistent index naming

* Exchange docs init

* Exchange docs

* Small portfolio changes

* Make some variables private

* More examples

* Ignore private variables and methods
@platschi platschi requested a review from Marko-roy August 2, 2023 15:36
@platschi
Copy link
Collaborator

platschi commented Aug 2, 2023

  • When coming from landing page, url shows ?accountType=smart_margin. When clicking Futures link in the Navigation, it defaults to ?accountType=cross_margin however.
Screen.Recording.2023-08-02.at.13.19.12.mov

@platschi platschi merged commit 9b34d73 into dev Aug 2, 2023
5 of 6 checks passed
@platschi platschi deleted the perps-v3 branch August 2, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants