Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: typos #2572

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Fix: typos #2572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6458031
Fix: typo
omahs Jul 8, 2023
e629d05
Fix: typo
omahs Jul 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/app/src/components/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Most of the components in this folder are viewable in our [Storybook]().

## Folder Structure

We try to ensure that folders are as flat as (reasonbly) possible. For this, reason, most individual components can be found under `{component-name}.tsx`. However in the future, some domain specific components may be found in subfolders like `mobile`, `futures` or `exchange`. The components are only expected to be used in the context of the folders in which they are contained.
We try to ensure that folders are as flat as (reasonably) possible. For this, reason, most individual components can be found under `{component-name}.tsx`. However in the future, some domain specific components may be found in subfolders like `mobile`, `futures` or `exchange`. The components are only expected to be used in the context of the folders in which they are contained.

## Checklist

Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ The following tasks are expected to be completed before the SDK can be considere
- [ ] Consider experimenting with WebSockets for realtime data (again).
- [ ] Remove walletAddress from connector and change references to the redux state wallet, this means we're always taking the sdk as source of truth for the wallet and avoids race conditions where queries are attempted before the signer is set.
- [ ] Add query statuses for all key queries and create derived query statuses for components which rely on completion of multiple queries
- [ ] Make all sdk number params consistent, e.g. use Wei everywhere insreads of BigNumber or string
- [ ] Make all sdk number params consistent, e.g. use Wei everywhere instead of BigNumber or string
- [ ] Remove Duplicated types.
- [ ] Create a standard way of passing in numeric values (particularly amounts) to the SDK. Weigh pros and cons of (`Wei`, `ethers.BigNumber` and `string`).
- [ ] Create interfaces for all the services, so we don't have to colocate method types and logic, especially when the types are verbose.
Expand Down
Loading