feat: remove bandit/security task

KyleKing · May 30, 2024 · ffddb52 · ffddb52
1 parent 1a0a6cd
commit ffddb52
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 98 deletions.
diff --git a/.calcipy_packaging.lock b/.calcipy_packaging.lock
@@ -63,14 +63,6 @@
         "name": "babel",
         "version": "2.15.0"
     },
-    "bandit": {
-        "datetime": "2024-03-08T19:25:54.618041+00:00",
-        "domain": "https://pypi.org/pypi/{name}/json",
-        "latest_datetime": "2024-03-08T19:25:54.618041+00:00",
-        "latest_version": "1.7.8",
-        "name": "bandit",
-        "version": "1.7.8"
-    },
     "basedpyright": {
         "datetime": "2024-05-29T13:03:04.128263+00:00",
         "domain": "https://pypi.org/pypi/{name}/json",
@@ -575,14 +567,6 @@
         "name": "pathspec",
         "version": "0.12.1"
     },
-    "pbr": {
-        "datetime": "2023-11-07T18:32:21.527935+00:00",
-        "domain": "https://pypi.org/pypi/{name}/json",
-        "latest_datetime": "2023-11-07T18:32:21.527935+00:00",
-        "latest_version": "6.0.0",
-        "name": "pbr",
-        "version": "6.0.0"
-    },
     "pip": {
         "datetime": "2024-02-03T09:53:09.575683+00:00",
         "domain": "https://pypi.org/pypi/{name}/json",
@@ -863,14 +847,6 @@
         "name": "sortedcontainers",
         "version": "2.4.0"
     },
-    "stevedore": {
-        "datetime": "2024-02-22T20:56:55.149691+00:00",
-        "domain": "https://pypi.org/pypi/{name}/json",
-        "latest_datetime": "2024-02-22T20:56:55.149691+00:00",
-        "latest_version": "5.2.0",
-        "name": "stevedore",
-        "version": "5.2.0"
-    },
     "syrupy": {
         "datetime": "2024-02-07T05:58:03.481215+00:00",
         "domain": "https://pypi.org/pypi/{name}/json",

diff --git a/calcipy/tasks/all_tasks.py b/calcipy/tasks/all_tasks.py
@@ -80,7 +80,6 @@ def with_progress(items: Any, offset: int = 0) -> TaskList:
     types.basedpyright,
     nox.noxfile.with_kwargs(session='tests'),    # pyright: ignore[reportFunctionMemberAccess]
     lint.pre_commit.with_kwargs(no_update=True),    # pyright: ignore[reportFunctionMemberAccess]
-    lint.security,
     tags.collect_code_tags,
     cl.write,
     pack.lock,

diff --git a/calcipy/tasks/lint.py b/calcipy/tasks/lint.py
@@ -5,7 +5,6 @@
 from beartype import beartype
 from beartype.typing import Optional
 from corallium.file_helpers import read_package_name
-from corallium.log import logger
 from invoke.context import Context
 
 from ..cli import task
@@ -79,18 +78,6 @@ def pylint(ctx: Context, *, report: bool = False) -> None:
     _inner_task(ctx, command='pylint', cli_args=cli_args)
 
 
-# ==============================================================================
-# Security
-
-
-@task()
-def security(ctx: Context) -> None:
-    """Attempt to identify possible security vulnerabilities."""
-    logger.warning('Note: Selectively override bandit with "# nosec"', is_header=True)
-    pkg_name = read_package_name()
-    run(ctx, f'{python_dir()}/bandit --recursive {pkg_name} -s B101')
-
-
 # ==============================================================================
 # Pre-Commit
 

diff --git a/docs/docs/CHANGELOG.md b/docs/docs/CHANGELOG.md
@@ -1,5 +1,10 @@
 ## Unreleased
 
+### Feat
+
+- remove bandit/security task
+- remove flake8
+
 ### Fix
 
 - remove semgrep

diff --git a/docs/docs/DEVELOPER_GUIDE.md b/docs/docs/DEVELOPER_GUIDE.md
@@ -73,14 +73,14 @@ poetry config pypi-token.pypi ...
 | `calcipy/tasks/defaults.py`                                     |           20 |         0 |          0 | 89.3%      |
 | `calcipy/tasks/doc.py`                                          |           45 |         0 |          8 | 90.5%      |
 | `calcipy/tasks/executable_utils.py`                             |           27 |         0 |          0 | 87.2%      |
-| `calcipy/tasks/lint.py`                                         |           51 |         1 |          0 | 83.5%      |
+| `calcipy/tasks/lint.py`                                         |           45 |         1 |          0 | 83.1%      |
 | `calcipy/tasks/nox.py`                                          |            8 |         0 |          0 | 100.0%     |
 | `calcipy/tasks/pack.py`                                         |           42 |        10 |          0 | 65.6%      |
 | `calcipy/tasks/stale.py`                                        |            9 |         1 |          0 | 90.9%      |
 | `calcipy/tasks/tags.py`                                         |           18 |         1 |          0 | 91.7%      |
 | `calcipy/tasks/test.py`                                         |           45 |         1 |          2 | 89.2%      |
 | `calcipy/tasks/types.py`                                        |           20 |         0 |          0 | 89.3%      |
-| **Totals**                                                      |         1024 |        67 |        262 | 87.1%      |
+| **Totals**                                                      |         1018 |        67 |        262 | 87.1%      |
 
 Generated on: 2024-05-29
 <!-- {cte} -->
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -35,7 +35,6 @@ version = "2.1.0"
 python = "^3.9.13"
 arrow = {optional = true, version = ">=1.2.3"} # tags
 autopep8 = {optional = true, version = ">=2.0.1"} # lint
-bandit = {optional = true, version = ">=1.7.4"} # lint
 basedpyright = {optional = true, version = ">=1.6.0"} # types
 beartype = ">=0.18.2"
 bidict = {optional = true, version = ">=0.22.1"} # stale
@@ -94,7 +93,6 @@ doc = [
 ]
 lint = [
   "autopep8",
-  "bandit",
   "pip-check",
   "ruff",
 ]

diff --git a/tests/tasks/test_lint.py b/tests/tasks/test_lint.py
@@ -2,8 +2,8 @@
 
 import pytest
 
-from calcipy.tasks.executable_utils import python_dir, python_m
-from calcipy.tasks.lint import autopep8, check, fix, pre_commit, pylint, security, watch
+from calcipy.tasks.executable_utils import python_m
+from calcipy.tasks.lint import autopep8, check, fix, pre_commit, pylint, watch
 
 
 @pytest.mark.parametrize(
@@ -16,9 +16,6 @@
         (fix, {}, [f'{python_m()} ruff check ./calcipy ./tests --fix']),
         (watch, {}, [f'{python_m()} ruff check ./calcipy ./tests --watch --show-source']),
         (pylint, {}, [f'{python_m()} pylint ./calcipy ./tests']),
-        (security, {}, [
-            f'{python_dir()}/bandit --recursive calcipy -s B101',
-        ]),
         (pre_commit, {}, [
             call('which pre-commit', warn=True, hide=True),
             'pre-commit install',