feat: shadow colors #1124
Merged
feat: shadow colors #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiniDigger
reviewed
Nov 1, 2024
api/src/main/java/net/kyori/adventure/text/format/ShadowColor.java
Outdated
Show resolved
Hide resolved
MiniDigger
reviewed
Nov 1, 2024
api/src/main/java/net/kyori/adventure/text/format/ShadowColor.java
Outdated
Show resolved
Hide resolved
|
We need a concept of "no shadow" that exists outside of creating a shadow colour with a magic number value. I'm also not sure I like the ShadowColor object existing as it does, I think I'd prefer it to be an interface implemented by either a singleton "none" object or a textcolor + alpha value. As we need some sort of ARGBLike interface (most platforms already have a colour + alpha object), I think we should try and ensure we don't duplicate API here. Ideally I think the API would allow for all of the following: style.shadowColor(ShadowColor.NONE);
style.shadowColor(ShadowColor.shadowColor(NamedTextColor.RED, 0.4);
style.shadowColor(NamedTextColor.RED);
style.shadowColor(myBukkitColorObject);
style.shadowColor(ShadowColor.shadowColor(0xRRGGBBAA); |
zml2008
reviewed
Dec 6, 2024
.../src/main/java/net/kyori/adventure/text/minimessage/tag/standard/ShadowColorTagResolver.java
Outdated
Show resolved
Hide resolved
|
this will need serializer support at some point too |
|
another thing we should add: a |
kashike
force-pushed
the
feature/shadow-color
branch
from
00fed47 to
de37bf6
Compare
|
I think this has everything on my list now |
kezz
previously requested changes
Dec 10, 2024
...inimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/StandardTags.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Kezz <kieran.wallbanks@gmail.com>
zml2008
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.