Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tied scores rebroken #882

Open
diediediebitch opened this issue Aug 28, 2023 · 5 comments
Open

tied scores rebroken #882

diediediebitch opened this issue Aug 28, 2023 · 5 comments
Labels
bug Something isn't working server:gameserver

Comments

@diediediebitch
Copy link

tied scores are supposed to be in order of time achieved so the top score should be whoever got it first. it might be in reverse order now but i can't tell

as u can see i got this score first
image

but now it puts me in last place instead of first
image

this was a issue i reported before and was fixed, don't know why it broke again

@diediediebitch diediediebitch added bug Something isn't working server:gameserver labels Aug 28, 2023
@sudokoko
Copy link
Member

#418 for reference

@sudokoko
Copy link
Member

sudokoko commented Aug 28, 2023

I will quickly check out our website code and potentially open a patch PR.

@Slendy
Copy link
Contributor

Slendy commented Aug 28, 2023

This is a side effect of 70a66e6. Scores never tracked time stamps so it was difficult to factor in the previous order of scores into the new system. In the future, order will be properly maintained by the time stamp the score was obtained.

@diediediebitch
Copy link
Author

im pretty sure the only problem is that these old tied scores are in reverse order, its the exact same issue i reported a few months ago and it was fixed.

@sudokoko
Copy link
Member

sudokoko commented Aug 29, 2023

70a66e6 SwitchScoreToUserIdMigration.cs L121

I believe this would be the cause. All old scores w/o a timestamp had their timestamps set to the time of when the migration occurred on the server. No real way to flip these - unless there is, however I'm not sure how we'd go about doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server:gameserver
Projects
None yet
Development

No branches or pull requests

3 participants