Skip to content

Commit

Permalink
Merge pull request #1421 from marc-vdm/CA-range-score-fix
Browse files Browse the repository at this point in the history
resolve faulty disable of `range` and `score` buttons
  • Loading branch information
mrvisscher authored Dec 23, 2024
2 parents 075f34e + 010259f commit 8f0b620
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
3 changes: 1 addition & 2 deletions activity_browser/docs/wiki/LCA-Results.md
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,7 @@ For `Range`, this is the full _range_ of results, for example, if all your negat
and all your positive results together have a score of 10, the _range_ is 12 (-2 * -1 + 10).
For `Score`, this is the total score (sum) of the results, for example, if all your negative results together have a
score of -2 and all your positive results together have a score of 10, the _score_ is 8 (-2 + 10).
The `Range` or `Score` setting are only used when 1) your Cut-off type is `Relative`
and 2) your results contain both positive and negative results.
The `Range` or `Score` setting are only used when your results contain both positive and negative results.

### Positive and negative numbers in contribution results
It can happen in LCA that you get both positive and negative numbers in your contribution results.
Expand Down
6 changes: 0 additions & 6 deletions activity_browser/layouts/tabs/LCA_results_tabs.py
Original file line number Diff line number Diff line change
Expand Up @@ -1112,12 +1112,6 @@ def update_tab(self):
QApplication.setOverrideCursor(QtCore.Qt.WaitCursor)
self.set_combobox_changes()

if self.cutoff_menu.limit_type == "percent":
self.total_menu.range.setEnabled(True)
self.total_menu.score.setEnabled(True)
else:
self.total_menu.range.setEnabled(False)
self.total_menu.score.setEnabled(False)
super().update_tab()
QApplication.restoreOverrideCursor()

Expand Down

0 comments on commit 8f0b620

Please sign in to comment.