CA updates + CA bugfixes + First-Tier contribution analysis tab #1046
+647
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…ty-browser into first_level_cont � Conflicts: � activity_browser/layouts/tabs/LCA_results_tabs.py
# Conflicts: # activity_browser/controllers/database.py # activity_browser/layouts/tabs/LCA_results_tabs.py
marc-vdm
changed the title
7 tasks
# Conflicts: # activity_browser/controllers/database.py # activity_browser/layouts/tabs/LCA_results_tabs.py
# Conflicts: # activity_browser/layouts/tabs/LCA_results_tabs.py
Add: - CA data: use actual total instead of sum(abs) - CA data: make distinction between positive and negative rest values (LCA-ActivityBrowser#886) - CA data: sort based on average of row instead of first column (LCA-ActivityBrowser#887) - CA table: consistent dropping of empty (rest) rows (LCA-ActivityBrowser#1044) - CA figure: add marker to show total score when both positive and negative results present (LCA-ActivityBrowser#647)
marc-vdm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 main items:
First Tier CA
What this does:
Show contributions of all intermediate flows (products) into the FU and the contributions of the FU itself, read more on the updated wiki page (in this PR)
Example project:
positive_negative_CA.tar.gz
Example:
Smaller changes
rangeorscoretotal for relative contributionsb0a610f/activity_browser/ui/tables/models/lca_results.py#L31)
Bugfixes
restrow sometimes doesn't show in table + index missing #1044)Known issues
scorefor relative contributions and result has both positive and negative results, CA will fail to correctly limit the results because of a bug in BW Analyzer (see Add cumulative percentage mode + small changes brightway-lca/brightway2-analyzer#32)Checklist
bug,feature,ui,change,documentation,breaking,cias they show up in the changelog