-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build lit actions and update cids when building sdk #698
base: master
Are you sure you want to change the base?
feat: build lit actions and update cids when building sdk #698
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think we need to document where do we get the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than add this logic into our pub.mjs, I'd really like to keep the logic encapsulated in NPM pre-publish hook in the package itself. Added a couple other comments in-line. Nice work getting this moving -- I ran into the dependency issue myself a few weeks ago but didn't figure out the explicit dep fix at the time. <3
…n files we can handle more easily
…hOnly and LA update its CIDs based on WKLAs code on install and publish
…pipeline-for-wk-las # Conflicts: # packages/wrapped-keys/package.json
Description
This PR:
wrapped-keys-lit-actions
and updates the associated CID inLIT_ACTION_CID_REPOSITORY
andLIT_ACTION_CID_REPOSITORY_COMMON
Both things are attached to our existing processes to enforce consistency of the built, referenced and published code
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
sync-actions-to-ipfs
script automatically on a publish dry runChecklist: