LIT-3935 - Auto-Top-Up - Fix 'is same day' calculation #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced `date-and-time` with `date-fns` and `@date-fns/tz` - Updated date calculations to correctly identify 'start of day' (midnight of same day instead of 23:00Z of prior day) - Added test for 'midnight today isSameDay as NOW' Just In Case ™️
MaximusHaximus
commented
Oct 6, 2024
| @@ -18,7 +18,7 @@ | |||
| "start": "pnpm build && node ./dist/worker/worker.js", | |||
| "prepare": "husky", | |||
| "ci_validate": "node ./dist/bin/validateJSONRecipients.js", | |||
| "validate": "pnpm tsc && node ./dist/bin/validateJSONRecipients.js" | |||
| "validate": "pnpm build && node ./dist/bin/validateJSONRecipients.js" | |||
There was a problem hiding this comment.
This was incorrectly running commit checks on the last built artifact instead of the current code in the repo.
FedericoAmura
approved these changes
Oct 7, 2024
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing 'midnight of today' math was incorrectly computing to 23:00Z of the prior day due to how
setHours()works w/ system timezone. I should have known better than to use any native JS date methods...date-and-timewithdate-fnsand@date-fns/tzFriends don't let friends use native Javascript Date objects. EVER. ;)