Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CI builds for RabbitMQ #89

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fixed CI builds for RabbitMQ #89

merged 1 commit into from
Oct 21, 2024

Conversation

lpottier
Copy link
Collaborator

@lpottier lpottier commented Sep 24, 2024

This PR adds RMQ tests to GitHub CI.

  • Added missing components (libevent and openssl) so our CI can handle RabbitMQ builds of AMS.
  • Test the AMSlib infrastructure to send messages to a RabbitMQ server
  • Test the AMS python side to read/consume messages

@ggeorgakoudis
Copy link
Member

How come the tests pass without changing the containers?

@lpottier
Copy link
Collaborator Author

lpottier commented Sep 24, 2024

I did not change the containers, I just updated the Dockerfile. I built them locally on my side to make sure it works. As AMS code did not change, and the containers did not change, everything is green.

@ggeorgakoudis
Copy link
Member

Can you add the tests in this PR? This change is dependent on the tests you want to add. What we should see is that the containerized tests fail, and (hopefully) succeed when the I build/upload the new containers and re-run the workflows.

@lpottier
Copy link
Collaborator Author

Hum good point, the tests are in another PR. I will merge both PRs.

@ggeorgakoudis
Copy link
Member

Are you adding also a gitlab test?

@lpottier
Copy link
Collaborator Author

Are you adding also a gitlab test?

Yes I would like to, I have to check how to do that.

@ggeorgakoudis
Copy link
Member

ggeorgakoudis commented Sep 25, 2024

Are you adding also a gitlab test?

Yes I would like to, I have to check how to do that.

Check the script ci-build-test.sh under scripts/gitlab. Gitlab CI invokes this script. You can add a function to call, where you run the rmq tests.

@koparasy
Copy link
Member

@lpottier what is the status of this. I can see that AMSlib cannot establish a connection with the server. Are we missing container changes?

@lpottier
Copy link
Collaborator Author

lpottier commented Oct 15, 2024

@koparasy No the containers are good now. I am working on it but the debugging has proven to be difficult (I cannot easily ssh into the GitHub runner). The Python tools using Pika are able to connect to the RabbitMQ container from the GitHub runner but the AMSlib fails to connect to RabbitMQ. This only happen in the GitHub runner, it works everywhere else (using the same container on LC machine etc).

I think its due to something when we connect to the service in the AMSlib specifically when the RabbitMQ service we connect to has no TLS enabled (so SSL is not needed). I am trying a few things to confirm that.

Signed-off-by: Loic Pottier <pottier1@llnl.gov>
@koparasy koparasy merged commit aa07df4 into develop Oct 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants