-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed CI builds for RabbitMQ #89
Conversation
How come the tests pass without changing the containers? |
I did not change the containers, I just updated the Dockerfile. I built them locally on my side to make sure it works. As AMS code did not change, and the containers did not change, everything is green. |
Can you add the tests in this PR? This change is dependent on the tests you want to add. What we should see is that the containerized tests fail, and (hopefully) succeed when the I build/upload the new containers and re-run the workflows. |
Hum good point, the tests are in another PR. I will merge both PRs. |
Are you adding also a gitlab test? |
Yes I would like to, I have to check how to do that. |
Check the script |
9ec5f64
to
984cd0a
Compare
@lpottier what is the status of this. I can see that AMSlib cannot establish a connection with the server. Are we missing container changes? |
@koparasy No the containers are good now. I am working on it but the debugging has proven to be difficult (I cannot easily ssh into the GitHub runner). The Python tools using Pika are able to connect to the RabbitMQ container from the GitHub runner but the AMSlib fails to connect to RabbitMQ. This only happen in the GitHub runner, it works everywhere else (using the same container on LC machine etc). I think its due to something when we connect to the service in the AMSlib specifically when the RabbitMQ service we connect to has no TLS enabled (so SSL is not needed). I am trying a few things to confirm that. |
dde08cc
to
4186b87
Compare
Signed-off-by: Loic Pottier <pottier1@llnl.gov>
4186b87
to
10e62a5
Compare
This PR adds RMQ tests to GitHub CI.
libevent
andopenssl
) so our CI can handle RabbitMQ builds of AMS.