GEOPM service for Caliper #213

amarathe84 · 2019-09-26T21:49:39Z

This PR is for the GEOPM service that we've developed for Caliper. The GEOPM service for Caliper enables transparently linking the GEOPM runtime system (https://github.com/geopm/geopm) for power management with the application through the Caliper markup API. The service captures region attribute updates and maps them to GEOPM application markups. The service handles updates to both OMP and non-OMP regions. The GEOPM markups are listed on this page: https://geopm.github.io/man/geopm_prof_c.3.html. The mapping between Caliper markups and GEOPM markups is listed in src/services/geopm/doc/GEOPM-mapping.pdf.

codecov-io · 2019-09-26T21:53:39Z

Codecov Report

Merging #213 into releases/v2.1.1 will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           releases/v2.1.1     #213   +/-   ##
================================================
  Coverage            75.67%   75.67%           
================================================
  Files                  123      123           
  Lines                 8065     8065           
================================================
  Hits                  6103     6103           
  Misses                1962     1962

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0593b0e...635b5dc. Read the comment docs.

amarathe84 · 2019-10-10T22:18:16Z

CMakeLists.txt

@@ -42,6 +42,7 @@ option(WITH_GOTCHA    "Enable GOTCHA wrapping" TRUE)
 option(WITH_SOS       "Enable SOSFlow data management" FALSE)
 option(WITH_TAU       "Enable TAU service (TAU Performance System)" FALSE)
 option(WITH_VTUNE     "Enable Intel(R) VTune(tm) annotation bindings" FALSE)
+option(WITH_GEOPM     "Enable GEOPM service" TRUE)


Set TRUE to FALSE

amarathe84 · 2019-10-10T22:20:30Z

CMakeLists.txt

+  include(FindGeopm)
+  if(GEOPM_FOUND)
+    message(STATUS "Found geopm.h in " ${GEOPM_INCLUDE_DIR})
+    message(STATUS "Found libgeopm.so in " ${GEOPM_LIBRARY})


Replace with GEOPM (check the list of messages at the end of CMakeLists.txt

Check line number CMakeLists.txt: 393

amarathe84 · 2019-10-10T22:23:36Z

cmake/FindGeopm.cmake

+# GEOPM_LIBRARY     - Name of GEOPM library file
+# GEOPM_FOUND       - True if GEOPM was found
+
+#set(GEOPM_INSTALL "" CACHE PATH "GEOPM install directory")


amarathe84 · 2019-10-10T22:24:59Z

src/services/geopm/CMakeLists.txt

+    )
+
+list(APPEND CALIPER_EXTERNAL_LIBS " -DDEBUGLEVEL=2")
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DDEBUGLEVEL=2")


Remove (do not usually change CFLAGS

amarathe84 · 2019-10-10T22:25:55Z

src/services/geopm/CMakeLists.txt

+    Geopm.cpp
+    )
+
+list(APPEND CALIPER_EXTERNAL_LIBS " -DDEBUGLEVEL=2")


Remove this

amarathe84 · 2019-10-10T22:26:05Z

src/services/geopm/CMakeLists.txt

+
+list(APPEND CALIPER_EXTERNAL_LIBS " -DDEBUGLEVEL=2")
+set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DDEBUGLEVEL=2")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DDEBUGLEVEL=2")


Remove this.

amarathe84 · 2019-10-10T22:36:19Z

src/services/geopm/Geopm.cpp

+    chn->events().pre_begin_evt.connect(::geopm_begin_region);
+    chn->events().pre_end_evt.connect(::geopm_end_region);


Migrate to annotation binding class (example NVPROF service code).

amarathe84 · 2019-10-10T22:40:52Z

src/services/geopm/Geopm.cpp

+         }
+    }
+
+    if(attr.name() == "annotation") {


Note: need to separate outermost annotation from individual kernel annotations.

amarathe84 · 2019-10-10T22:42:51Z

src/services/geopm/Geopm.cpp

+        /* Start of a loop in the application, initialize loop count
+         * to update fractional progress later
+         */
+        if(regionname.to_string() == "mainloop") {


Make the outer loop name configuration.

amarathe84

Measure overhead of Caliper service + GEOPM.

amarathe84 · 2019-10-10T22:47:22Z

src/services/geopm/Geopm.cpp

+     */
+
+    /* check if the attribute type is annotation, loop or function, and create a region ID. */
+    if(attr.name() == "annotation") {


Look up built-in attributes by ID instead of strings.

amarathe84 · 2019-10-10T22:54:03Z

src/services/geopm/Geopm.cpp

+
+void geopm_begin_region(Caliper* c, Channel* chn, const Attribute& attr, const Variant& regionname) {
+    int err;
+    std::string sRegionName(regionname.to_string());


Find out the scope of annotation attribute (process or thread).

amarathe84 · 2019-10-10T22:58:18Z

src/services/geopm/Geopm.cpp

+         if(geopm_phase_map.end() == geopm_phase_map.find(sRegionName)) {
+             uint64_t phase_rid = GEOPM_NULL_VAL; 
+             geopm_prof_region(sRegionName.c_str(), GEOPM_REGION_HINT_COMPUTE, &phase_rid);
+             geopm_phase_map.insert(std::pair<std::string, uint64_t>(sRegionName, phase_rid));


Figure out if we can avoid string copy.

amarathe84 · 2019-10-10T23:02:17Z

src/services/geopm/Geopm.cpp

+         * to update fractional progress later
+         */
+        if(regionname.to_string() == "mainloop") {
+            /* Nothing to do at the start of the mainloop */


Refactor this part of the code

amarathe84 · 2019-10-10T23:10:05Z

src/services/geopm/Geopm.cpp

+        } else {
+            /* This is neither the main loop nor an OpenMP loop, 
+             * therefore, mark process-level progress */
+            geopm_prof_progress(geopm_phase_map[sRegionName], 


Make sure there is no division by zero (exists check)

amarathe84 added 6 commits September 26, 2019 14:13

Refreshed GEOPM service for v2.1.1

9b643cf

Redundant message in CMakeLists

49be453

Updated documentation

9df48e5

Updated events

2d2ebe4

Updated documentation

8f7e4bc

Updated documentation

635b5dc

amarathe84 commented Oct 10, 2019

View reviewed changes

src/services/geopm/CMakeLists.txt

Geopm.cpp

)

list(APPEND CALIPER_EXTERNAL_LIBS " -DDEBUGLEVEL=2")

Copy link

Author

amarathe84 Oct 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

amarathe84 commented Oct 10, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GEOPM service for Caliper #213

GEOPM service for Caliper #213

amarathe84 commented Sep 26, 2019

codecov-io commented Sep 26, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 left a comment

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

amarathe84 Oct 10, 2019

		chn->events().pre_begin_evt.connect(::geopm_begin_region);
		chn->events().pre_end_evt.connect(::geopm_end_region);

GEOPM service for Caliper #213

Are you sure you want to change the base?

GEOPM service for Caliper #213

Conversation

amarathe84 commented Sep 26, 2019

codecov-io commented Sep 26, 2019

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amarathe84 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment