Caliper support for builtin Kokkos Tools (continued)

[mzuzek]

@ibaned @crtrott
This is continuation/extension of #397 by @DavidPoliakoff

Status

• Done:
  • Support for configuration string in cali::get_event_set()
  • Minor fixes
• Done by @DavidPoliakoff in Caliper support for builtin Kokkos Tools #397:
  • Expose Kokkos EventSet via cali::get_event_set() for flexible KokkosTools integration.

Example

See full example that connects Caliper to Kokkos via KokkosTools - using proposed EventSet-based approach:

int main(int argc, char *argv[]) {
  auto eventSet = KokkosTools::get_event_set("caliper",
                                             "runtime-report(profile.kokkos)");
  Kokkos::Tools::Experimental::set_callbacks(eventSet);

  Kokkos::initialize(argc, argv);
  // ... run app ... //
  Kokkos::finalize();
  return 0;
}

[mzuzek]

Should cali::get_event_set() be exposed in a Caliper header ?
If so, which one would be the best for that ?

[daboehme]

Hi @MikolajZuzek , thanks for working on this.

Should cali::get_event_set() be exposed in a Caliper header ? If so, which one would be the best for that ?

If it only ever needs to be called from the Kokkos library we can probably just extern it. If it needs to be in a header it's probably best of in its own, like cali_kokkos.h.

For the functions themselves: I think it would be better to name them cali::get_kokkos_event_set and cali::set_kokkos_cali_config() to make it more explicit that they're for Kokkos.

[mzuzek]

Hi @daboehme!
Thank you for your answer and suggestions. My apologies for the delay on this reply.

I renamed the functions to what you've suggested, rebased this PR on current master and added some fixes for MSVC.

Let me convert this PR to draft for now: I guess it'll only make sense to merge it together or after kokkos/kokkos-tools#131.

[daboehme]

Let me convert this PR to draft for now: I guess it'll only make sense to merge it together or after kokkos/kokkos-tools#131.

Ok, sounds good. Let me know when this is ready to go in.

[vlkale]

@mzuzek cc. @daboehme I happened to come across this just now while looking at Caliper documentation, and I see that it was blocked at the time by the CMake build PR for Kokkos Tools. But, that CMake Build PR has been merged into Kokkos Tools develop branch. Are you able to finish and/or merge this PR now?

[mzuzek]

Hi @vlkale.

I've been reassigned to other things even before CMake build PR was merged into Kokkos Tools (kokkos/kokkos-tools#159) and, unfortunately, I'm not able to engage here at present...

PS. I guess you might first need Caliper team's insight on what would it take to get this PR finalized and merged.