add note about unit stride to layout #1736
Open
+65
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kab163
approved these changes
Sep 18, 2024
| @@ -55,20 +55,31 @@ which we define as: | |||
| :language: C++ | |||
|
|
|||
There was a problem hiding this comment.
Maybe we can add a warning about RAJA View performance?
Suggested change
| .. warning:: In order to get the best performance out of ``RAJA::View``, be sure you are building in release mode (i.e. make sure you don't have a debug build when doing performance comparisons). |
¯_(ツ)_/¯
There was a problem hiding this comment.
I feel like building with release for performance is a given, and adding a statement like that might actually be more confusing (does building optimized with debug symbols degrade performance?).
There was a problem hiding this comment.
If you use -G in a Cuda build it removes kernel optimizations
There was a problem hiding this comment.
But -lineinfo should not, right?
There was a problem hiding this comment.
OK, I leave it up to you whether you want to add this note.
There was a problem hiding this comment.
I can go either way, what do others think?
artv3
commented
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a note in the documentation regarding unit stride for RAJA::layouts