-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHAI Submodule #285
CHAI Submodule #285
Conversation
…fter 3.14 w/ latest BLT.
… dependent target Spheral_CXX properties; Bringing in Axom correctly; Bringing in chai, raja and umpire through CMake.
…ripts call in build stage.
…ding wanrings as errors.
…ommand in real-time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look good to me. One question -- there are a number of changes to the PYB11Generator submodule in this pull request. Are these in a sub-branch of PYB11Generator? We may want to pull those changes to the master branch there so we can keep everything in sync and not have Spheral pointing at non-standard changes to the PYB11.
@jmikeowen Good catch on that. I need to check what those changes are, but I don't believe we need them anymore. I think they were from when I was investigating the umpire linking issue a few weeks ago. |
@jmikeowen We don't NEED the PYB11Generator changes for this PR but we will need them relatively soon so we might as well bring them in here. I went ahead and made a PR LLNL/PYB11Generator#9, let's get the PYB11Generator PR in first before merging this. |
Summary
v0.9.0
cmake_minimum_version
reduced to3.14
. This was required due to failing device_link stage in NVCC builds w/ the newest Axom. Probably linked to how BLT handles CUDA.ToDo :
RELEASE_NOTES.md
with notable changes.