Fix warnings: zeroing non-trivial type

Fix several warnings of the following form:

Warnung: »void* memset(void*, int, size_t)« Säubern eines Objekts von nichttrivialem Typ »class lmms::sampleFrame«; use assignment or value-initialization instead [-Wclass-memaccess]

include/DummyInstrument.h

@@ -51,8 +51,7 @@ class DummyInstrument : public Instrument
 
 	void playNote( NotePlayHandle *, sampleFrame * buffer ) override
 	{
-		memset( buffer, 0, sizeof( sampleFrame ) *
-			Engine::audioEngine()->framesPerPeriod() );
+		zeroSampleFrames(buffer, Engine::audioEngine()->framesPerPeriod());
 	}
 
 	void saveSettings( QDomDocument &, QDomElement & ) override

include/lmms_basics.h

@@ -281,6 +281,16 @@ class sampleFrame
 	std::array<sample_t, DEFAULT_CHANNELS> m_samples;
 };
 
+inline void zeroSampleFrames(sampleFrame* buffer, fpp_t frames)
+{
+	//memset(buffer, 0, sizeof( sampleFrame ) * frames);
+
+	for (fpp_t i = 0; i < frames; ++i)
+	{
+		buffer[i] = sampleFrame();
+	}
+}
+
 constexpr std::size_t LMMS_ALIGN_SIZE = 16;
 
 

plugins/AudioFileProcessor/AudioFileProcessor.cpp

@@ -165,7 +165,7 @@ void AudioFileProcessor::playNote( NotePlayHandle * _n,
 		}
 		else
 		{
-			memset( _working_buffer, 0, ( frames + offset ) * sizeof( sampleFrame ) );
+			zeroSampleFrames(_working_buffer, frames + offset);
 			emit isPlaying( 0 );
 		}
 	}

plugins/CarlaBase/Carla.cpp

@@ -504,7 +504,7 @@ void CarlaInstrument::play(sampleFrame* workingBuffer)
 {
     const uint bufsize = Engine::audioEngine()->framesPerPeriod();
 
-    std::memset(workingBuffer, 0, sizeof(sample_t)*bufsize*DEFAULT_CHANNELS);
+	zeroSampleFrames(workingBuffer, bufsize);
 
     if (fHandle == nullptr)
     {

plugins/CrossoverEQ/CrossoverEQ.cpp

@@ -139,7 +139,7 @@ bool CrossoverEQEffect::processAudioBuffer( sampleFrame* buf, const fpp_t frames
 
 	m_needsUpdate = false;
 
-	memset( m_work, 0, sizeof( sampleFrame ) * frames );
+	zeroSampleFrames(m_work, frames);
 
 	// run temp bands
 	for( int f = 0; f < frames; ++f )

plugins/Patman/Patman.cpp

@@ -160,7 +160,7 @@ void PatmanInstrument::playNote( NotePlayHandle * _n,
 	}
 	else
 	{
-		memset( _working_buffer, 0, ( frames + offset ) * sizeof( sampleFrame ) );
+		zeroSampleFrames(_working_buffer, frames + offset);
 	}
 }
 

plugins/Sfxr/Sfxr.cpp

@@ -454,7 +454,7 @@ void SfxrInstrument::playNote( NotePlayHandle * _n, sampleFrame * _working_buffe
 	}
 	else if( static_cast<SfxrSynth*>(_n->m_pluginData)->isPlaying() == false )
 	{
-		memset(_working_buffer + offset, 0, sizeof(sampleFrame) * frameNum);
+		zeroSampleFrames(_working_buffer + offset, frameNum);
 		_n->noteOff();
 		return;
 	}

src/core/BufferManager.cpp

@@ -47,7 +47,7 @@ sampleFrame * BufferManager::acquire()
 
 void BufferManager::clear( sampleFrame *ab, const f_cnt_t frames, const f_cnt_t offset )
 {
-	memset( ab + offset, 0, sizeof( *ab ) * frames );
+	zeroSampleFrames(ab + offset, frames);
 }
 
 

src/core/RingBuffer.cpp

@@ -38,7 +38,7 @@ RingBuffer::RingBuffer( f_cnt_t size ) :
 	m_size( size + m_fpp )
 {
 	m_buffer = new sampleFrame[ m_size ];
-	memset( m_buffer, 0, m_size * sizeof( sampleFrame ) );
+	zeroSampleFrames(m_buffer, m_size);
 	m_position = 0;
 }
 
@@ -49,7 +49,7 @@ RingBuffer::RingBuffer( float size ) :
 {
 	m_size = msToFrames( size ) + m_fpp;
 	m_buffer = new sampleFrame[ m_size ];
-	memset( m_buffer, 0, m_size * sizeof( sampleFrame ) );
+	zeroSampleFrames(m_buffer, m_size);
 	m_position = 0;
 	setSamplerateAware( true );
 	//qDebug( "m_size %d, m_position %d", m_size, m_position );
@@ -64,7 +64,7 @@ RingBuffer::~RingBuffer()
 
 void RingBuffer::reset()
 {
-	memset( m_buffer, 0, m_size * sizeof( sampleFrame ) );
+	zeroSampleFrames(m_buffer, m_size);
 	m_position = 0;
 }
 
@@ -75,7 +75,7 @@ void RingBuffer::changeSize( f_cnt_t size )
 	sampleFrame * tmp = m_buffer;
 	m_size = size;
 	m_buffer = new sampleFrame[ m_size ];
-	memset( m_buffer, 0, m_size * sizeof( sampleFrame ) );
+	zeroSampleFrames(m_buffer, m_size);
 	m_position = 0;
 	delete[] tmp;
 }
@@ -123,18 +123,18 @@ void RingBuffer::pop( sampleFrame * dst )
 	if( m_position + m_fpp <= m_size ) // we won't go over the edge so we can just memcpy here
 	{
 		memcpy( dst, & m_buffer [ m_position ], m_fpp * sizeof( sampleFrame ) );
-		memset( & m_buffer[m_position], 0, m_fpp * sizeof( sampleFrame ) );
+		zeroSampleFrames(&m_buffer[m_position], m_fpp);
 	}
 	else
 	{
 		f_cnt_t first = m_size - m_position;
 		f_cnt_t second = m_fpp - first;
 
 		memcpy( dst, & m_buffer [ m_position ], first * sizeof( sampleFrame ) );
-		memset( & m_buffer [m_position], 0, first * sizeof( sampleFrame ) );
+		zeroSampleFrames(&m_buffer[m_position], first);
 
 		memcpy( & dst [first], m_buffer, second * sizeof( sampleFrame ) );
-		memset( m_buffer, 0, second * sizeof( sampleFrame ) );
+		zeroSampleFrames(m_buffer, second);
 	}
 
 	m_position = ( m_position + m_fpp ) % m_size;
@@ -312,7 +312,7 @@ void RingBuffer::updateSamplerate()
 	m_samplerate = Engine::audioEngine()->processingSampleRate();
 	delete[] m_buffer;
 	m_buffer = new sampleFrame[ m_size ];
-	memset( m_buffer, 0, m_size * sizeof( sampleFrame ) );
+	zeroSampleFrames(m_buffer, m_size);
 	m_position = 0;
 }
 

src/core/SamplePlayHandle.cpp

@@ -91,7 +91,7 @@ void SamplePlayHandle::play( sampleFrame * buffer )
 	//play( 0, _try_parallelizing );
 	if( framesDone() >= totalFrames() )
 	{
-		memset( buffer, 0, sizeof( sampleFrame ) * fpp );
+		zeroSampleFrames(buffer, fpp);
 		return;
 	}
 
@@ -101,7 +101,7 @@ void SamplePlayHandle::play( sampleFrame * buffer )
 	// apply offset for the first period
 	if( framesDone() == 0 )
 	{
-		memset( buffer, 0, sizeof( sampleFrame ) * offset() );
+		zeroSampleFrames(buffer, offset());
 		workingBuffer += offset();
 		frames -= offset();
 	}
@@ -116,7 +116,7 @@ void SamplePlayHandle::play( sampleFrame * buffer )
 		// it is used only for previews, SampleTracks and the metronome.
 		if (!m_sample->play(workingBuffer, &m_state, frames, DefaultBaseFreq))
 		{
-			memset(workingBuffer, 0, frames * sizeof(sampleFrame));
+			zeroSampleFrames(workingBuffer, frames);
 		}
 	}