Widgets left not themeable

[IvanMaldonado]

Based on a post made in #1839 I have made a list of the things that are not still themable at all or individually.

List of currently unthemeable items

• Title bars Title Bar Theming Support #2450
• Mixer background color Make the mixer color editable #2704
• b+b editor background b+b editor background is linked to the mutedBackgroundColor #2634
• Help text boxes
• Border styles
• Side menu styles

Themeable, but need improvement

• Qt Tooltips (Radius)

---

Screenshots:
Mixer background color #2704
b+b editor background #2634
QTooltip radius

General settings/Buffer size section

Buttons in general

Help textbox

Sidemenu

The sidebar gradient is vertical

Border style of some elements.

And plugins in general, not sure how viable this is, but skins for lmms plugins could be a good idea.

These are the ones I have found so far, I have removed some elements on my list because I decided they would be Fixes rather than editables. (Some elements that are not well centred, misused space, elements that are related in the .css file, etc...) As an example, the "sidebar gradient is vertical" could be considered something to fix because it is already editable, same with the QTooltip radius.

I can post the rest of the issues here or I can open another Issue asking for fixes and I can move the examples given there, whatever is better.

[tresf]

Thanks @IvanMaldonado.

Can you please change this to checklist format and either hyperlink the images or organize them a bit better so it's easier to read/track. Also, it may be worth mentioning (related because it's for styling, although not a duplicate):

#2510 (comment)

[liushuyu]

@tresf I'm confirming this...

[tresf]

@liushuyu Please feel free to amend the original post as needed (since you have access to). 👍

[liushuyu]

@IvanMaldonado Sorry, but I can't figure out what are the problems with General settings/Buffer size section and General Buttons ? What do you want to change about these widgets?

[liushuyu]

@tresf Okay

@IvanMaldonado I have edited your issue per @tresf 's request, please feel free to correct it if I was wrong XD

[IvanMaldonado]

It's ok, I'm fine with any modification to my post in order to make it more redeable .
@liushuyu The problem of the general settings/Buffer size section is the scroll bar.
And one can not change the form of the general buttons, nor their borders or the aspect they have when you hover on them.

[liushuyu]

@IvanMaldonado That makes more sense now, thanks for your clarification!

[RebeccaDeField]

Thanks for getting this list together @IvanMaldonado 👍

[michaelgregorius]

@IvanMaldonado It seems that the top-bottom sidebar gradient is rather a problem with the style sheet that you use. In the original style sheet the gradient goes from left to right. Here's a screenshot with adjusted colors to make it more clear:

The original style sheet looks as follows:

background: qlineargradient(x1:0, y1:0, x2:1, y2:0, stop: 0 #98a2a7, stop: 1.0 #5b646f);

I guess you have it set to something like (0, 0) -> (0, 1) instead of (0, 0) -> (1, 0).

[Umcaruje]

skins for lmms plugins could be a good idea.

You can already do that. You just put the files necessary into a plugins folder. Here's an example: https://github.com/StakeoutPunch/LMMS_Themes/tree/master/uiX/plugins

[IvanMaldonado]

@michaelgregorius You're right, it was my bad 🌵
@Umcaruje I see, so if I make a folder called plugins, will lmms scan for the skins automatically? also, how do I know how to name each element of each plugin? and... currently the LSP just allows you to upload 1MB files, which I don't think will be enough for a theme with skins for every plugin.

EDIT: I have removed the vertical sidebar theming problem since it was a mistake of mine and not an actual problem 👍 I will post the other stuff I found later, I want to check them out deeply this time.

[Umcaruje]

how do I know how to name each element of each plugin?

Look at its source code. Example: https://github.com/LMMS/lmms/tree/master/plugins/audio_file_processor

You can see all the necessary png's there. You just need to rename them to be like PluginName_ImageName.png. Note that this will change with #1891, where you will have seperate folders and not prefixes. That PR is not going to go into 1.2 so you shouldn't worry about it.

currently the LSP just allows you to upload 1MB files, which I don't think will be enough for a theme with skins for every plugin.

That's a valid concern. @tresf should we perhaps make larger files uploadable to LSP? Do we have enough server room?

[tresf]

That's a valid concern. @tresf should we perhaps make larger files uploadable to LSP? Do we have enough server room?

👍 LMMS/lmms.io@df05bf8

[Umcaruje]

👍 awesome!