-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Qt 6 support #6614
Comments
Opened #7133 to replace |
does this still affect post the removal of |
I saw we could use Clazy to port much of the Code to Qt6, Here is the doc page: https://doc.qt.io/qt-6/porting-to-qt6-using-clazy.html, I already tried it out and it works good, This Page is also an great Resource for Porting over: https://doc.qt.io/qt-6/portingguide.html |
|
Pull request #7179 handles the removal of |
#7182 is now in a mergeable state. Would help if anyone from here would review it. |
Hi @Rossmaxx, I have checked out the branch and have run CMake as follows:
This leads to the following error with regards to ZynAddSubFx:
|
I'd like to propose to create a "qt6-migration" branch in the official repository using the changes already done in #7182. That way the code could be worked on collaboratively without the need for intermediate pull requests until everything compiles/works. Once that state is reached there could then be one "official" pull request using that branch where some final "polishing" might be discussed. |
@michaelgregorius i forgot about that one. For now, cmake configuration only works if you set |
Thanks for the info, @Rossmaxx! |
@Rossmaxx, I have made adjustments to your branch so that minimal mode now fully compiles. Is it okay if I push the changes into your branch? |
Yes please. |
Ok, great! Done with commit bb4d04b. |
Here's a list of the build warnings that are currently given when building commit 684afdb from @Rossmaxx's repository: build_warnings.zip. We will need to check how to deal with the different types of warnings. If we are lucky they can be fixed without some version specific Edit: the file was created with the following command in the build directory:
|
Any ideas on what to do here? |
The last parameter has type of |
Depending on the surrounding code this might also be solvable with a helper method that uses a type as the last parameter that's defined via a So similar to what was for example done for |
#7212 has gotten rid of the requirement for 32 bit qt for 64 bit windows. Check it off? |
For anyone interested: that branch is now available at https://github.com/LMMS/lmms/tree/qt6. |
Added to #7086 |
Fantastic work! Mac tested, works. I tested with Unfa Spoken demo track and it sounds fine. Commands (click to expand):brew install git cmake pkgconfig fftw libogg libvorbis lame libsndfile libsamplerate jack \
fluid-synth sdl2 libgig libsoundio stk portaudio node fltk qt glib
# ^--- changed "qt5" to "qt"
rm -rf lmms
git clone --recurse-submodules -b master https://github.com/lmms/lmms
cd lmms
git checkout qt6
export CMAKE_PREFIX_PATH=$(brew --prefix qt)
# ^--- changed "qt5" to "qt"
mkdir build
cd build
cmake .. -DCMAKE_INSTALL_PREFIX=../target -DWANT_QT6=true
# ^--- added flag
make -j8
./lmms AFAIR the DMG creation script on master is broken, so I didn't test that. Will sort that on master in a separate issue/PR. |
Feel free to work on that qt6 branch. As of now, the plan is to do everything there and open one final PR consisting of all changes. |
If we decide to keep Mingw support around, we would require a PPA for this. There seems to be some disagreement on Discord as to whether or not this is worthwhile to keep around. Pinging @tobydox as an FYI in the event we decide to keep it. <3
Sorry, this probably wasn't clear but the DMG issues are unrelated to Qt6. Master's DMG is only 46 MB currently (should be ~100MB) , so something's been wrong on nightly for quite some time. I'll investigate this issue and fix it directly on master. |
I spoke too soon, some are. PR opened. #7240
This bug is present on master too, removing. |
After applying the changes from #7086, it builds successfully for me (using Qt 6.7.1 and Visual Studio 2022). I'm happy to help debug your particular configuration, but it might be better to do that on Discord so as not to clutter this issue. |
Forgot that that PR had a fix. Will close that PR and open a new one against the qt6 branch. |
done via #7254 |
I have disabled X11 embedding for now in #7273
We don't need to, since I disabled it instead along with X11 embedding.
It would be better to not use 32 bit for Qt6 anyway, 32 bit builds can still use Qt5 (but mark 32 bit as deprecated as 1.3 and remove for future version) Another item worth adding to the original checklist is handle removal of |
fixed in #7274 |
Potentially unpopular opinion: I would be fine dropping 32-bit OS support entirely (NOT 32-bit VST support)
Areas where I can see 32-bit staying strong would be DIY/hobbyist/embedded systems, but those would be very specific use-cases and may be better suited for a core/UI separation effort. |
I do agree but for that 1% of users who are still using pentiums, let them have a better version with less bugs. |
With that mentality, why not offer 32-bit Linux binaries? We can now, thanks to #7252. Egh... Let's look at this from 1,000 feet:
The data is stacked against any notion of keeping 32-bit around; If our aim is to move forward, dropping 32-bit is a step in the right direction. Arguments against this should come with fact and data, not grandeur. <3 Lastly, keeping "support" for 32-bit in the codebase is NOT THE SAME as removing it from our downloads. There's still people compiling LMMS against PPC, but there's absolutely no expectation of it appearing in our downloads area. |
Alright i agree completely now. |
I can't wrap my head around what to do over here. Pinging @PhysSong for assistance (I'm a bit unfamiliar with qt code in that area so would rather delegate it to you) |
Yeah it would likely be a refactor, but I'm really not sure how breaking this is to our codebase... These days I use a trackpad with LMMS almost exclusively. The areas that we check for mouse direction are historically up/down. Although we may also want to support left/right explicitly, in my experience it "just works". For example (Qt5:)
I feel like this point may be unrelated to Qt6 as a whole and better suited for general usability improvements, to the likes of:
I too would like some more context as to this Qt6 requirement @PhysSong |
Quoting one of my comments in #5619(also linked in the post):
This introduces a behavioral change: a diagonal scroll input won't result in actual diagonal scrolling anymore in case there is some direction-dependent logic that is not properly upgraded for Qt 6. |
Thanks, however, it is still not clear to me the implication of this change. I read most of #5619 and I still do not understand the implication of this change. |
Here's a list of all classes that override
The list is a slightly filtered result of |
Seconded. What @tresf wrote is gold here. The code can be still kept 32-bit-compatible if anyone wants to put that effort in, but first-class support for almost totally obsolete technology simply drains available dev resources really quickly. Can we go with e.g. a ticket created explicitly for dropping 32-bit support or something similar? The sooner the better, IMO - TBH, while working on updating parts of LMMS, trying to maintain 32-bit-compatibility in the build process got messy really quickly. E.g. https://github.com/FyiurAmron/lmms/actions/runs/9260084064/job/25473203303 is just a real-world example of that. While 64-bit compilation finally went ahead with no problem, I'm still debugging what's exactly wrong with the 32-bit one :D Side note: I'm mostly a Windows 7 user (sic!), but if someone would say "let's drop support for Windows 7", I wouldn't bat an eye, as long as 7 wouldn't be artificially blocked from running the executable. I often use obsolete OSes and apps, but that doesn't mean I want the core devs wasting time on supporting them instead of doing more important stuff, like fixing bugs or adding long-awaited features. |
@michaelgregorius i got a random idea just now. Instead of disabling x11 embed, is there a way we can make it work using |
@Rossmaxx, I have no real overview of the X11 embed implementation and |
Hopefully, we will get done with 2.0 and different frontends by the time qt 6 will reach eol. Also, i believe we will find a better solution by then. I am looking for better solution now too tbh. The best solution for the embedding problem which i got was, believe it or not, disabling embedding but there are some ui related backlash for that solution, that's why i didn't go that route. I do hope to find a more long lasting solution by the time we land qt 6 on master. |
Working branch: https://github.com/LMMS/lmms/tree/qt6
As 2023-05-26 is the EOL of Qt 5.15(without subscription licenses), it's worth starting working on Qt 6 support. Since we require C++17 and has helpers for deprecated Qt features, it might be not as hard as adding Qt 5 support.
See here for more information about how to port from Qt5 to Qt6: https://doc.qt.io/qt-6/portingguide.html
I made a checklist for Qt 6 support. Please feel free to suggest something to add.
QRegExp
withQRegularExpression
(Replace QRegExp with QRegularExpression #7133): Removed in Remove MemoryManager #7128MM_OPERATORS
confilcts withgetDefaultCtr
/getCopyCtr
/getMoveCtr
ofQMetaTypeInterface
forSampleBuffer
QApplication::desktop
gui_templates.h
: useQWidget
's DPI instead(or entirely remove, if possible) (Font size adjustments #7185)ComboBox.cpp
: useQWidget
's DPI instead(or entirely remove, if possible) (Remove use of QApplication::desktop in ComboBox.cpp #7179)QAbstractNativeEventFilter::nativeEventFilter
in Qt 6 (Handle signature changes for nativeEventFilter for qt6 #7254)qt5-x11embed
to support Qt 6 or drop XEmbed support for Qt 6 (dropped in Enabled VSTs on Qt 6 #7273)QWheelEvent
may have both x and y deltas, potentially breakingSongEditor::wheelEvent
(see Qt deprecation fix #5619 (comment))QComboBox::activated(const QString&)
is renamed totextActivated
in Qt 5.14, breaking signal-slot connectionsThe text was updated successfully, but these errors were encountered: