Mixer LEDs and labels are cropped at 2x scaling #7052
Labels
Comments
michaelgregorius
added a commit
to michaelgregorius/lmms
that referenced
this issue
Jan 7, 2024
Fix the scaling of `PixmapButton` when used in layouts. In this case `PixmapButton::sizeHint` is queried which used `devicePixelRatio` to divide the size of the active pixmap. As a result the size is always the same in pixels regardless of the scaling factor of the application. This is fixed by removing the calls. Example: If the scaling factor is 2 then the pixmap will also report twice the size in pixels and hence request more space in layouts, etc. However, if we divide by the device/pixel ratio then the original size of the image/pixmap will be reported and therefore it will be too small in layouts. The calls to `devicePixelRatio` have been introduced with pull request LMMS#4950 (via commit c3b4d51) which replaced the old Spectrum Analyzer. The pixmaps of the Spectrum Analyzer still look good with this change. Fixes LMMS#7052.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Probably related to #6591 (@sakertooth) as mentioned by M. Gregorius in #7045 -- when LMMS runs at 2x scale, the LED checkboxes in Mixer do not scale up its boundary and get cropped. Some of the longer labels also have a similar issue and their first letter is getting cropped.
Left: a few months old build, right: build from #7045, including the new mixer:
The mixer also takes up quite a bit more space now, fitting only 18 buses where it previously displayed 24, and leaving space for at least one less track. Not sure if that was intentional. While it does not look as crammed as before, it would be nice to have an option to switch back to a version with more compact margins. But that would be a feature request, so unrelated to this bug report.
The text was updated successfully, but these errors were encountered: