Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using integrate in Xpressive crashes LMMS #7468

Open
1 task done
khoidauminh opened this issue Aug 25, 2024 · 3 comments · May be fixed by #7499
Open
1 task done

Using integrate in Xpressive crashes LMMS #7468

khoidauminh opened this issue Aug 25, 2024 · 3 comments · May be fixed by #7499
Labels
bug

Comments

@khoidauminh
Copy link
Contributor

khoidauminh commented Aug 25, 2024 •
edited
Loading

System Information

Archlinux

LMMS Version(s)

Master

Most Recent Working Version

Before #7379

Bug Summary

Arithmetic exception triggered by the integrate function in Xpressive.

Expected Behaviour

Should not crash

Steps To Reproduce

  1. In LMMS, load the default preset of Xpressive or any preset that contains integrate,
  2. Click on the O1 button.

Logs

Loading the default preset: gdb.txt

Empty preset and typing integrate(f) into O1: gdb2.txt

Screenshots / Minimum Reproducible Project

Screencast.from.2024-08-25.09-43-27.webm

Please search the issue tracker for existing bug reports before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
@Rossmaxx
Copy link
Contributor

@gnudles you have any idea?

@gnudles
Copy link
Contributor

gnudles commented Aug 25, 2024

@Rossmaxx I will look into that, thanks. Maybe there is an undefined behaviour error.

@gnudles
Copy link
Contributor

gnudles commented Sep 14, 2024 •
edited
Loading

@Rossmaxx
851c884#diff-e474279d8fff8dbea1526e155470b2d712583ef3ceb0903a20d03088825d5802

someone replaced the line
for (i = 0; i < length; i++) {
with this
for (auto i = std::size_t{0}; i < length; i++) {

I was using the reference of i internally, and this change created a different variable.

opened a pull request:
#7499

@gnudles gnudles linked a pull request Sep 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash on Xpressive when using integrate function gnudles/lmms
3 participants
@gnudles @Rossmaxx @khoidauminh