-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixer channels unmute for solo recursive #6746
base: master
Are you sure you want to change the base?
Mixer channels unmute for solo recursive #6746
Conversation
When soled one FX channel, unmute send and receive channels, to allow complex FX channel routing (BUS, SENDs, etc.)
Activate also SEND channels recursively
Hey @superpaik, I'm looking to get this merged soon if possible. Are you able to fix the merge conflicts? I'm also wondering if the code could be simplified a bit (not sure about this as of right now, but just a thought).
I don't think this is much of an issue. IMO, after we isolate the signal paths a certain mixer channel can take to reach master, it should be fine as the user can mute whatever path they do not want after the fact. |
Hi @sakertooth . I've been out of the project for a while now. Feel free to take it from here if you will. |
…eForSoloRecursive Conflicts: * include/Mixer.h
Make the mixer channel index `m_channelIndex` private and add getters and setters. Also add a method to determine if the channel is the master channel. Move `m_channelIndex` to the end of the initialization list of the `MixerChannel` constructor because it is now the last member in the header. Adjust all clients to make use of the new methods.
Implements/solve an existing TO-DO in the code of the function MixerChannel::unmuteForSolo() (//TODO: Recursively activate every channel, this channel sends to).
The problem is that when a channel sends audio to other channels, leaving that channel on "solo" doesn't make much sense (for example, you have an specific channel for "High Percs" and it is send to a "Drums Bus Channel" than then goes to master)
It is also true when other channels send audio to the one soloed (for example, if you set a "Drums Bus Channel" that receives from all drums channels - Kick, High Perc, Low Perc, etc.-)
Now when a channel is soloed (not including the master channel), all sends to and receives from this channel are unmuted so the audio is correctly send to master. This allows complex mixer channel routing (BUS, SENDs, etc.) to work properly and increases the mixer's usability.