Refactor ArpDirection::Down and ArpDirection::DownAndUp #7007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonkmachine
changed the title
Fix issue with wrong pattern when going down and cycle is over 0.
zonkmachine
force-pushed
the
arpeggiorefactor
branch
from
325df3b
to
ab5bdc1
Compare
DomClark
approved these changes
Mar 30, 2024
|
Merge? |
Nope. I think I just found a glitch. |
Fixed. Here is a demo project. It's just an arpeggio over four bars going down. On master the starting note of the arpeggio will change when you turn up Cycle. The start note should be the same no matter the setting of Cycle. |
|
Now merge? |
Found an older issue. More testing... |
I had failed testing some parts when developing the 'Repeats' function. This has now been taken care of in the last two commits. |
messmerd
approved these changes
Apr 3, 2024
sakertooth
approved these changes
Apr 3, 2024
enp2s0
pushed a commit
to enp2s0/lmms
that referenced
this pull request
Apr 12, 2024
Fixes an issue with the arpeggiation when it is set to go downwards and the cycle is over 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with wrong pattern when going down and cycle is over 0.
Working on #6478 I spotted an issue with the arpeggio pattern when using cycle. This issue was present on the initial implementation of the cycle function. In order to produce similar results, up and down they are now treated the same and later inverted if they are
ArpDirection::DownorArpDirection::DownAndUp.