Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor gui_templates.h #7159

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Refactor gui_templates.h #7159

merged 10 commits into from
Mar 27, 2024

Commits on Mar 24, 2024

  1. remove the gui_templates header where functions not used

    @Rossmaxx
    Rossmaxx committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    44c95f8 View commit details
    Browse the repository at this point in the history

  2. refactor and replace template with function argument

    @Rossmaxx
    Rossmaxx committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    63799cc View commit details
    Browse the repository at this point in the history

  3. refactor: merge pointSizeF function with pointSize

    @Rossmaxx
    Rossmaxx committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    2945a6c View commit details
    Browse the repository at this point in the history

  4. missed these

    @Rossmaxx
    Rossmaxx committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    832cf78 View commit details
    Browse the repository at this point in the history

  5. removed template per michael's review

    @Rossmaxx
    Rossmaxx committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    137b5d5 View commit details
    Browse the repository at this point in the history

  6. use std::max for more readability

    @Rossmaxx
    Rossmaxx committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    296583e View commit details
    Browse the repository at this point in the history

  7. remove the QDesktopWidget header

    @Rossmaxx
    Rossmaxx committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    76cf4a7 View commit details
    Browse the repository at this point in the history

  8. headers

    @Rossmaxx
    Rossmaxx committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    9513333 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. cleanup arguments and remove parantheses from return

    @Rossmaxx
    Rossmaxx committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1f2cba0 View commit details
    Browse the repository at this point in the history

  2. namespace gui

    @Rossmaxx
    Rossmaxx committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9ce2993 View commit details
    Browse the repository at this point in the history