-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean src/core/ A* #7163
base: master
Are you sure you want to change the base?
Clean src/core/ A* #7163
Conversation
df4bfbb
to
3748815
Compare
Putting this as ready for review since you mentioned you were requesting review. |
Oh. big important Co-authored-by: saker <sakertooth@gmail.com>
Removed the |
Thank you. There are still a few things I want to get through, and I have a very clogged schedule presently, but I will get to this as soon as I can. I forgot "ready for review" meant a label of a PR ready for review, and my request for reviewing was to make sure I didn't accidentally eat a bracket or something(as you have noticed and pointed out, thank you!), and I need to get through this once more, and implement the rest of your suggestions along with anything else that is appropriate. |
Now it is ✔️ |
CI should be able to catch such oversights. I will merge this in 2 days if no one objects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update some more style 👍
Co-authored-by: Kevin Zander <veratil@gmail.com>
Co-authored-by: Kevin Zander <veratil@gmail.com>
I have a change of mind now. I have decided to wait for some "possibly conflicting PRs". I will continue maintaining this branch tho. |
Update to coding conventions.
Some cases I might be unsure. Requesting review.
This PR will have the src/core/ files starting with A.
Doing a set at a time.
Covers:
src/core/* :
AudioEngine.cpp
AudioEngineProfiler.cpp
AudioEngineWorkerThread.cpp
AudioResampler.cpp
AutomatableModel.cpp
AutomationClip.cpp
AutomationNode.cpp