-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the steps in the Pattern Editor scalable #7175
Open
michaelgregorius
wants to merge
7
commits into
LMMS:master
Choose a base branch
from
michaelgregorius:3683-ScalableBnBSteps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Make the steps in the Pattern Editor scalable #7175
michaelgregorius
wants to merge
7
commits into
LMMS:master
from
michaelgregorius:3683-ScalableBnBSteps
Commits on Mar 28, 2024
-
Replace the pngs of the step buttons with the svgs from the previous branch. Adjust the code so they are rendered with the maximum available height.
Configuration menu - View commit details
-
Copy full SHA for 97c48ca - Browse repository at this point
Copy the full SHA 97c48caView commit details -
Ensure minimal height of 24 pixels like the pngs. Take border offsets into account.
Configuration menu - View commit details
-
Copy full SHA for 26677a4 - Browse repository at this point
Copy the full SHA 26677a4View commit details -
Fix mouse clicks for larger step buttons
Fix the method `mousePressEvent` so that it also works with the larger step buttons. The main change is the adjusted check for the y coordinate. All other changes are just refactoring and reformatting of the method's code.
Configuration menu - View commit details
-
Copy full SHA for 1b1df06 - Browse repository at this point
Copy the full SHA 1b1df06View commit details
Commits on Apr 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 75c1acf - Browse repository at this point
Copy the full SHA 75c1acfView commit details -
Extract step computation in method
Extract the computation of the selected step into a dedicated method in `MidiClipView`. The removes duplicated code in the mouse press and wheel event handling code. The method `getStep` returns an `std::optional` which contains the value of the step if the calculation was successful. It also contains the check for the height. The calculation with floats was removed in `getStep` as it should not be necessary. Adjust `MidiClipView::wheelEvent` so that it now computes the step in the same way as the mouse event handler. This reinstates the functionality to set the note velocities with the mouse wheel even if the beat pattern is enlarged.
Configuration menu - View commit details
-
Copy full SHA for 0959b6d - Browse repository at this point
Copy the full SHA 0959b6dView commit details -
Install SVGs in theme directories
Adjust `data/themes/CMakeLists.txt` so that SVGs in the theme directories are also installed.
Configuration menu - View commit details
-
Copy full SHA for eb80173 - Browse repository at this point
Copy the full SHA eb80173View commit details
Commits on Apr 22, 2024
-
Fix artifacts that occur when Qt is requested to render SVGs into very small pixmaps. This is done by making sure that the SVG is always rendered into pixmaps that are at least 24x24 in size (the size of the original PNG pixmap). Adjust the pixmap drawing code so that a potentially larger source pixmap is drawn into a smaller target pixmap.
Configuration menu - View commit details
-
Copy full SHA for 6797678 - Browse repository at this point
Copy the full SHA 6797678View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.