Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use layouts for the instrument sound shaping tab / Extract classes for Envelope and LFO graphs #7193

Commits on Apr 4, 2024

  1. Add class EnvelopeGraph

    Move the rendering of the envelope graph into it's own class.
    
    This is a preparation step to use layouts in `EnvelopeAndLfoView`. It does not work with the mixed in painting in the paint event.
    michaelgregorius committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5c93d8d View commit details
    Browse the repository at this point in the history
  2. Move LFO graph into its own class

    Move the LFO graph into its own class. This finally enables the removal of the mouse event and paint event code in `EnvelopeAndLfoView`.
    
    Make the enum `LfoShape` in `EnvelopeAndLfoParameters` public so that it can be used without friend declarations. Add accessor methods for the model of the LFO.
    michaelgregorius committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b32c934 View commit details
    Browse the repository at this point in the history
  3. EnvelopeAndLfoView with layout

    Use layouts to align the elements of the `EnvelopeAndLfoView`. This removes lots of hard-coded values.
    
    Add helper lambdas for the repeated creation of `Knob` and `PixmapButton` instances.
    
    The spacing between the envelope and LFO should be removed once there is a more open layout.
    michaelgregorius committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    1f71d65 View commit details
    Browse the repository at this point in the history
  4. Layouts for InstrumentSoundShapingView

    Use layouts to align the elements of the `InstrumentSoundShapingView`.
    michaelgregorius committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    4373003 View commit details
    Browse the repository at this point in the history
  5. Info text improvements in LFO graph

    Draw the info text at around 20% of the LFO graph's height. This prepares the dialog to be scaled later.
    
    Write "1000 ms/LFO" instead of "ms/LFO: 1000" with a larger gap.
    michaelgregorius committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    3de4e19 View commit details
    Browse the repository at this point in the history
  6. Merge remote-tracking branch 'upstream/master' into InstrumentSoundSh…

    …apingWithLayout
    
    Conflicts:
    * src/gui/instrument/EnvelopeAndLfoView.cpp
    * src/gui/instrument/InstrumentSoundShapingView.cpp
    michaelgregorius committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    d8b5cf7 View commit details
    Browse the repository at this point in the history
  7. Code review changes

    Whitespace and formatting.
    michaelgregorius committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    5007b8e View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2024

  1. Code review changes

    * Remove some "pragma once" for now
    * Adjust include orders
    * Variable initialization in headers
    * Prevention of most vexing parses
    michaelgregorius committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    618707f View commit details
    Browse the repository at this point in the history