-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use layouts for the instrument sound shaping tab / Extract classes for Envelope and LFO graphs #7193
Use layouts for the instrument sound shaping tab / Extract classes for Envelope and LFO graphs #7193
Commits on Apr 4, 2024
-
Move the rendering of the envelope graph into it's own class. This is a preparation step to use layouts in `EnvelopeAndLfoView`. It does not work with the mixed in painting in the paint event.
Configuration menu - View commit details
-
Copy full SHA for 5c93d8d - Browse repository at this point
Copy the full SHA 5c93d8dView commit details -
Move LFO graph into its own class
Move the LFO graph into its own class. This finally enables the removal of the mouse event and paint event code in `EnvelopeAndLfoView`. Make the enum `LfoShape` in `EnvelopeAndLfoParameters` public so that it can be used without friend declarations. Add accessor methods for the model of the LFO.
Configuration menu - View commit details
-
Copy full SHA for b32c934 - Browse repository at this point
Copy the full SHA b32c934View commit details -
EnvelopeAndLfoView with layout
Use layouts to align the elements of the `EnvelopeAndLfoView`. This removes lots of hard-coded values. Add helper lambdas for the repeated creation of `Knob` and `PixmapButton` instances. The spacing between the envelope and LFO should be removed once there is a more open layout.
Configuration menu - View commit details
-
Copy full SHA for 1f71d65 - Browse repository at this point
Copy the full SHA 1f71d65View commit details -
Layouts for InstrumentSoundShapingView
Use layouts to align the elements of the `InstrumentSoundShapingView`.
Configuration menu - View commit details
-
Copy full SHA for 4373003 - Browse repository at this point
Copy the full SHA 4373003View commit details -
Info text improvements in LFO graph
Draw the info text at around 20% of the LFO graph's height. This prepares the dialog to be scaled later. Write "1000 ms/LFO" instead of "ms/LFO: 1000" with a larger gap.
Configuration menu - View commit details
-
Copy full SHA for 3de4e19 - Browse repository at this point
Copy the full SHA 3de4e19View commit details -
Merge remote-tracking branch 'upstream/master' into InstrumentSoundSh…
…apingWithLayout Conflicts: * src/gui/instrument/EnvelopeAndLfoView.cpp * src/gui/instrument/InstrumentSoundShapingView.cpp
Configuration menu - View commit details
-
Copy full SHA for d8b5cf7 - Browse repository at this point
Copy the full SHA d8b5cf7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5007b8e - Browse repository at this point
Copy the full SHA 5007b8eView commit details
Commits on Apr 5, 2024
-
* Remove some "pragma once" for now * Adjust include orders * Variable initialization in headers * Prevention of most vexing parses
Configuration menu - View commit details
-
Copy full SHA for 618707f - Browse repository at this point
Copy the full SHA 618707fView commit details