Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize sample waveform rendering time #7210

Closed
wants to merge 6 commits into from
Closed

Minimize sample waveform rendering time #7210

wants to merge 6 commits into from

Commits on Apr 17, 2024

  1. Reorganize SampleWaveform::visualize 

    Eliminates vector allocation.

Reduces the number of frames to process per pixel index from 512 down to 16.

Restructure the 2 loops and move some math out of the loops.
    @khoidauminh
    khoidauminh authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    2ebcee6 View commit details
    Browse the repository at this point in the history

  2. Fix code styling and remove unnecessary variables

    @khoidauminh
    khoidauminh authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b446a8b View commit details
    Browse the repository at this point in the history

  3. Remove the blank line so CodeFactor is happy

    @khoidauminh
    khoidauminh authored Apr 17, 2024
    Configuration menu
    Copy the full SHA
    10fead7 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2024

  1. Rename variables to match naming convention and remove an unncessary … 

    …variable
    @khoidauminh
    khoidauminh authored Apr 20, 2024
    Configuration menu
    Copy the full SHA
    caf856b View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2024

  1. Merge branch 'LMMS:master' into enhance-perf

    @khoidauminh
    khoidauminh authored Apr 21, 2024
    Configuration menu
    Copy the full SHA
    ee5fe64 View commit details
    Browse the repository at this point in the history

  2. Bump maxFramesPerPixel to 24 for a more accurate waveform

    @khoidauminh
    khoidauminh authored Apr 21, 2024
    Configuration menu
    Copy the full SHA
    3006b66 View commit details
    Browse the repository at this point in the history