Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: new effect rack interface and features #7242

Closed
wants to merge 3 commits into from
Closed

Conversation

enp2s0
Copy link
Contributor

@enp2s0 enp2s0 commented May 6, 2024

This is still a heavy work-in-progress PR.

  • Remove the broken gate knob
  • EffectView redesign
    • Remove fixed-width pixmaps; support arbitrary widths; use QT layouts rather than fixed positioning
    • Hide the decay knob if plugin auto quit is disabled
    • Shrink vertical height of effects
    • Make EffectView respect theming options/colors
    • Open effect UI by clicking on effect name a la SongEditor

@Rossmaxx
Copy link
Contributor

Rossmaxx commented May 9, 2024

It would be beneficial if you add screenshots here.

@michaelgregorius
Copy link
Contributor

I was requested as a reviewer but I am wondering if this PR is already ready for review? The title still says "WIP" and not all checkmarks are checked yet.

@Rossmaxx
Copy link
Contributor

Oops mb. Shouldn't have rushed the review call.

@Rossmaxx Rossmaxx marked this pull request as draft May 29, 2024 18:41
@Rossmaxx
Copy link
Contributor

I converted it to draft because it's a WIP. Change it back if it's ready.

@enp2s0
Copy link
Contributor Author

enp2s0 commented Jun 14, 2024

yes this is a WIP. Still working on it although I expect to have it wrapped up soon

@Rossmaxx
Copy link
Contributor

If you don't mind, can you spin off the gate knob removal into it's own seperate Pull Request? Makes it easier to review

@enp2s0
Copy link
Contributor Author

enp2s0 commented Aug 7, 2024

Replaced by #7438.

@enp2s0 enp2s0 closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants