Adds Item Starring and other FileBrowser changes #7419
Conversation
Undo whitespace changes in `SideBarWidget` so that is unchanged by the pull request.
Move the method `addContentCheckBox` to the other private methods. Remove the method parameters because it can use the members. Remove the conditional when adding the "Hidden content" checkbox because it was always true.
Fix some formatting to keep the diff as small as possible.
|
I haven't built and tested this branch yet but the PR is a bit messy. It looks like your master wasn't up to date with lmms/master when you coded this. Instead it's based on an earlier PR that already got merged but that was squashed down to one commit. This one: https://github.com/LMMS/lmms/pull/7309/commits |
Yeah i know. I spent ages trying to fix it and put it into It's own branch but couldnt figure out a way to. |
Item Starring
Added the ability to star items. This gets added to its own tab named "Starred Items". note that this required a minor config change. I'm unsure whether this counts as a new config version.
Minor Changes:
nautilus,dolphin,thunar,pcmanfm,nemo,caja,io.elementary.files,spacefm,pcmanfm-qtand any other file manager that supports the--selectcli option can easilly be added. note that this falls back to the old system if a compatible file manager can't be found.I am very sorry about the huge diff. at some point my IDE decided to use the .clang-format to reformat everything without me noticing.
This has been tested on Linux (manjaro, gnome) only. I will test Windows soon.
I have tried to add screen recordings but for some reason my screen recording software isn't working. I will edit this with recordings when I can