Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixer EffectRackView GUI glitch #7511

Closed
wants to merge 3 commits into from

Conversation

Rossmaxx
Copy link
Contributor

@Rossmaxx Rossmaxx commented Sep 19, 2024

fixes: #7508, #7510

@Rossmaxx
Copy link
Contributor Author

It seems fixed on my end. It would help if anyone else confirms the fix.

@PhysSong PhysSong linked an issue Sep 19, 2024 that may be closed by this pull request
1 task
@zonkmachine
Copy link
Member

... #7510

This seem to fix the mixer effect chain gui but not the instrument effect chain.

@Rossmaxx
Copy link
Contributor Author

Rossmaxx commented Sep 19, 2024

Zonk can you clarify with screenshots?

@sakertooth
Copy link
Contributor

This is the problem @zonkmachine is referring to @Rossmaxx.
image

@sakertooth
Copy link
Contributor

I don't think it was right to merge the instrument & effect chain resize changes in #7453. I feel like that PR should have been more focused on making SlicerT use the resize changes after they were implemented in another PR rather than it implementing them and then using it. It would have make reviewing a bit easier I think, and we would've had a better chance at catching these problems.

@Rossmaxx
Copy link
Contributor Author

Thanks saker, I'll look into that too.

@Rossmaxx
Copy link
Contributor Author

I tried to fix the instrument effect view getting chopped but couldn't figure out what file to actually edit. I tried a couple different files but none of those fixed it.

I'll be afk for a few days so if someone finds a fix, feel free to push to this branch and merge this.

@@ -289,7 +289,7 @@ InstrumentTrackWindow::InstrumentTrackWindow( InstrumentTrackView * _itv ) :
flags |= Qt::MSWindowsFixedSizeDialogHint;
// any better way than this?
} else {
subWin->setMaximumSize(m_instrumentView->maximumHeight() + 12, m_instrumentView->maximumWidth() + 208);
subWin->setMaximumSize(m_instrumentView->maximumWidth() + 12, m_instrumentView->maximumHeight() + 208);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to use setFixedSize here rather than calling both setMinimumSize and setMaximumSize?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this has got something to do with resize ability

@Rossmaxx
Copy link
Contributor Author

Closing in favour of #7519

@Rossmaxx Rossmaxx closed this Sep 26, 2024
@Rossmaxx Rossmaxx deleted the fix-mixer-bug branch September 28, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout issues after SlicerT UI update Mixer bugs and unpleasant changes
4 participants