adding Sample Folder #7538
Draft
adding Sample Folder #7538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to add a way and a place to store sample files for projects.
A new class is added called
SampleFolder. It will store audio files in 2 ways: relative (Project Folder) and absolute (inside a folder that can store all audio files for multiple projects).All sample loading and saving should be routed through
SampleFolder.SampleFolderclass will store a tag inside the saved file paths to decide if they (the files) should be loaded by it. This means for example thatSampleClipwill store a file path that could be normal (absolute) or it could be relative (with a special tag appended to the file name).SampleClipwill not have to store an additional boolean to decide if it should load the sample with theSampleFolderclass, it won't even have to know about where the sample is loaded from. This means that old projects are not effected by this change and if implemented all used samples can be copied to a relative Project Folder.This PR is not finished and it is not implemented.