Remove deprecated code in GigPlayer #7540
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `CountInstruments` and `GetInstrument` instead of the deprecated methods `GetFirstInstrument` and `GetNextInstrument`. Use `CountRegions` and `GetRegionAt` instead of the deprecated `GetFirstRegion` and `GetNextRegion`. Both changes turn `while` loops into `for` loops.
|
Ok, now I have found out why this was never fixed. It looks like the Linux and mingw builds use older versions of libgig. |
|
In #7162, similar deprecations are fixed using a temporary method, which i believe would suit this PR too. But that PR happens to have gone stale as the original author left. I did take over that one but stopped using windows since. I will get around to completing it but can't tell when. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
CountInstrumentsandGetInstrumentinstead of the deprecated methodsGetFirstInstrumentandGetNextInstrument.Use
CountRegionsandGetRegionAtinstead of the deprecatedGetFirstRegionandGetNextRegion.Both changes turn
whileloops intoforloops.