Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Novelbin #1162

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Update Novelbin #1162

wants to merge 6 commits into from

Conversation

CD-Z
Copy link
Contributor

@CD-Z CD-Z commented Aug 22, 2024

adds covers to search results
removes novelbin source tags from chaptertext

@@ -7,8 +7,8 @@ class NovelBin implements Plugin.PluginBase {
id = 'novelbin';
name = 'Novel Bin';
icon = 'src/en/novelbin/icon.png';
site = 'https://binnovel.com/';
version = '1.0.1';
site = 'https://lightnovel.novelupdates.net/';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This site redirects me to https://novelbin.com/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Novelbin redirects back to it in a chapter and for some reason it seems that this site isn't cloudflare protected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I think you should use https://lightnovel.novelupdates.net/ for building chapter url instead of changing the domain

@CD-Z CD-Z marked this pull request as draft August 23, 2024 06:04
@CD-Z CD-Z marked this pull request as ready for review August 23, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants