ReLibrary: Fix loading scraping+loading covers when a novel is parsed #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagami
reviewed
Dec 4, 2024
|
|
||
| imageRequestInit: Plugin.ImageRequestInit = { | ||
| headers: { | ||
| Referer: ReLibraryPlugin.site, |
There was a problem hiding this comment.
Should be this.site instead? I dont think site is a static attribute
| @@ -316,10 +344,10 @@ class ReLibraryPlugin implements Plugin.PluginBase { | |||
| } | |||
| chapters.push({ | |||
| name: loadedCheerio(chap_el).text(), | |||
| path: chap_path, | |||
| path: ReLibraryPlugin.trim_slashes(chap_path), | |||
There was a problem hiding this comment.
should be this.trim_slashes instead
Comment on lines
+175
to
+179
| private static trim_slashes(url: string): string { | ||
| while (url.startsWith('/')) url = url.slice(1); | ||
| while (url.endsWith('/')) url = url.slice(0, url.length - 1); | ||
| return url; | ||
| } |
There was a problem hiding this comment.
be careful, after this changes, novels in popular and search would be treated as new novels (though they were installed) because the path is not same as in the database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix that makes it possible to load covers from a parsed novel.
There is also a small fix that will trim
/from the urls when storing them. this should be a utilty function to prevent code duplication in my optinion (my version is not good though);I don't know if this is a site specific thing, but all the
imgtags had thesrcattribute non-existant by default (aka when transmitted over the wire), but an attribute nameddata-cfsrcwas present with the same value as the loaded website on a browser.Currently my solution is to check both and prefer
img.srcif it exitsbumped version to 1.1.0, maybe a smaller bump should be used but I don't know :)
To note: the plugin does work normally now.