QCD, pileup, parton showering uncs. #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rkansal47
commented
Jun 26, 2024
rkansal47
commented
- QCD scale and PDF acceptance shape uncertainties
- Pileup for all MC
- ISR/FSR parton showering uncertainties for signal only
- Test
cmantill
reviewed
Jun 26, 2024
|
|
||
| if wshift == "scale": | ||
| # renormalization / factorization scale uncertainty is the max/min envelope of the variations | ||
| shape_up = np.max(whists.values(), axis=0) |
There was a problem hiding this comment.
I am not sure this is correct. Shouldn't it be shape_up of all the variations except (4) and then compare that with weight (4)?
There was a problem hiding this comment.
There was a problem hiding this comment.
The weights should already be with respect to the nominal (4) from the skimmer.
| nom_vals = h[sample, :].values() | ||
| abs_unc = np.linalg.norm( | ||
| (whists.values() - nom_vals), axis=0 | ||
| ) # / np.sqrt(103) |
There was a problem hiding this comment.
why is # / np.sqrt(103) commented? maybe get rid of it?
There was a problem hiding this comment.
Yes it is not necessary (wasn't sure before).
Sorry I don't think I have time for that today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.