Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extrapad #83

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix extrapad #83

wants to merge 4 commits into from

Commits on Oct 10, 2023

  1. let tests work offline

    Tests did not work when working offline.
    This was because forestplot.dataframe_utils.load_data
    and forestplot.tests.test_plot.py were trying to access csv's from
    https://github.com/LSYS/forestplot/tree/main/examples/data.
    To fix this, a option for setting an environment variable FORESTPLOT_OFFLINE=1
    and an argument data_path to forestplot.dataframe_utils.load_data was added.
    This makes it possible to provide a path to the directory containing csv's to load_data
    and setting FORESTPLOT_OFFLINE=1 makes it fail immediately if unsuccesful.
    EythorE committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4009386 View commit details
    Browse the repository at this point in the history
  2. fix large extrapad when effects and ci were large

    extrapad was calculated as xlim[1] * (1 + extrapad) which becomes extremely large when effects are not close to 0.
    These lines were refactored into a function _get_pad() which
    uses the range xlim[1] - xlim[0] as reference to compute the pad, which fixes the issue.
    EythorE committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    5fee627 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    10bc9b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. Configuration menu
    Copy the full SHA
    4e01b92 View commit details
    Browse the repository at this point in the history