Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Target Type #5

Open
dudleycodes opened this issue Oct 8, 2022 · 0 comments
Open

Idea: Target Type #5

dudleycodes opened this issue Oct 8, 2022 · 0 comments
Assignees

Comments

@dudleycodes
Copy link
Member

Right now, our use case is only for testing Docker images. But in the future we might want to open it up to other types of tests (local CLI utilities, remote CLI over SSH, etc). So, what if expanded the yaml template for target to require a type attribute?

target:
    type: docker-image
    ....

This way, if/when we add new targets, ShellAndTest could be cleanly expanded in that direction?

For now, we could just require target: type: docker-image to be provided. If it's missing, throw an error that target type must be specified, and if it is anything else other than docker-image it throws an error target type x not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants