UI/AppKit: Handle window resize events during live resizing

This lets us redraw the WebView while live resize events are ongoing. By doing so, we can also update the window rect from within the WebView, rather than requiring a separate method invocation (which the Inspector and Task Manager windows were missing).
LadybirdBrowser · Nov 8, 2024 · 4ae1bca · 4ae1bca
1 parent 3bbe1b0
commit 4ae1bca
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 12 deletions.
diff --git a/Ladybird/AppKit/UI/InspectorController.mm b/Ladybird/AppKit/UI/InspectorController.mm
@@ -55,9 +55,7 @@ - (void)windowWillClose:(NSNotification*)notification
 
 - (void)windowDidResize:(NSNotification*)notification
 {
-    if (![[self window] inLiveResize]) {
-        [[[self inspector] web_view] handleResize];
-    }
+    [[[self inspector] web_view] handleResize];
 }
 
 - (void)windowDidChangeBackingProperties:(NSNotification*)notification

diff --git a/Ladybird/AppKit/UI/LadybirdWebView.mm b/Ladybird/AppKit/UI/LadybirdWebView.mm
@@ -196,6 +196,9 @@ - (void)setWindowSize:(Gfx::IntSize)size
 
 - (void)handleResize
 {
+    auto size = Ladybird::ns_size_to_gfx_size([[self window] frame].size);
+    [self setWindowSize:size];
+
     [self updateViewportRect];
     [self updateStatusLabelPosition];
 }

diff --git a/Ladybird/AppKit/UI/TabController.mm b/Ladybird/AppKit/UI/TabController.mm
@@ -623,12 +623,7 @@ - (void)windowDidResize:(NSNotification*)notification
     self.location_toolbar_item_width = [[[self.location_toolbar_item view] widthAnchor] constraintEqualToConstant:width];
     self.location_toolbar_item_width.active = YES;
 
-    if (![[self window] inLiveResize]) {
-        [[[self tab] web_view] handleResize];
-    }
-
-    auto size = Ladybird::ns_size_to_gfx_size([[self tab] frame].size);
-    [[[self tab] web_view] setWindowSize:size];
+    [[[self tab] web_view] handleResize];
 }
 
 - (void)windowDidChangeBackingProperties:(NSNotification*)notification

diff --git a/Ladybird/AppKit/UI/TaskManagerController.mm b/Ladybird/AppKit/UI/TaskManagerController.mm
@@ -54,9 +54,7 @@ - (void)windowWillClose:(NSNotification*)notification
 
 - (void)windowDidResize:(NSNotification*)notification
 {
-    if (![[self window] inLiveResize]) {
-        [[[self taskManager] web_view] handleResize];
-    }
+    [[[self taskManager] web_view] handleResize];
 }
 
 - (void)windowDidChangeBackingProperties:(NSNotification*)notification