Skip to content

Commit

Permalink
Tests: Use FileSystem::real_path when comparing paths
Browse files Browse the repository at this point in the history
Paths in `headless-browser` tests were being compared by string value.
With this patch, they will be compared by their real path instead,
ensuring relative paths and symlinks are handled correctly.
  • Loading branch information
yyny authored and trflynn89 committed Nov 7, 2024
1 parent 87dd871 commit b625a92
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Ladybird/Headless/Test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ static ErrorOr<void> load_test_config(StringView test_root_path)
for (auto const& group : config->groups()) {
if (group == "Skipped"sv) {
for (auto& key : config->keys(group))
s_skipped_tests.append(LexicalPath::join(test_root_path, key).string());
s_skipped_tests.append(TRY(FileSystem::real_path(LexicalPath::join(test_root_path, key).string())));
} else {
warnln("Unknown group '{}' in config {}", group, config_path);
}
Expand Down

0 comments on commit b625a92

Please sign in to comment.