LibDNS+LibWeb+Ladybird+RequestServer: Let there be DNS over TLS #2111
+2,723
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimpfard
force-pushed
the
dns-base
branch
6 times, most recently
from
a38d166
to
73e401a
Compare
alimpfard
force-pushed
the
dns-base
branch
7 times, most recently
from
34f9268
to
884986a
Compare
ADKaster
reviewed
Nov 5, 2024
alimpfard
force-pushed
the
dns-base
branch
3 times, most recently
from
ea0b8da
to
6920745
Compare
ADKaster
reviewed
Nov 9, 2024
Ladybird/HelperProcess.cpp
Outdated
| @@ -161,7 +161,19 @@ ErrorOr<NonnullRefPtr<Requests::RequestClient>> launch_request_server_process(Re | |||
| arguments.append(server.value()); | |||
| } | |||
|
|
|||
| return launch_server_process<Requests::RequestClient>("RequestServer"sv, candidate_request_server_paths, move(arguments)); | |||
| auto client = TRY(launch_server_process<Requests::RequestClient>("RequestServer"sv, candidate_request_server_paths, move(arguments))); | |||
| WebView::Application::chrome_options().dns_settings.visit( | |||
There was a problem hiding this comment.
Is there a reason to do this via an explicit IPC message after process creation, or could it be added to the request server top-level arguments?
There was a problem hiding this comment.
I'm a big proponent of not having to restart the application just to change your DNS settings.
We could add it to the command line parameters, but imo this is nicer (just one way to set DNS in RS)
alimpfard
force-pushed
the
dns-base
branch
4 times, most recently
from
54bac0a
to
1c8a3f3
Compare
This is a footgun with some massive bullets.
This just unifies the API for all three sockets (UDP, TCP and TLS)
This commit adds our own DNS resolver, with the aim of implementing DoT (and eventually DoH, maybe even DNSSEC etc.)
This can now happen due to the hostname not existing, as RS explicitly performs DNS resolution before setting up the response pipe.
In the future, we may want to parse /etc/hosts (or equivalent) into the cache; this commit only adds localhost to make the normal workflow work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.