LibWeb: Implement enough of IndexedDB to pass some WPT open tests #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stelar7
force-pushed
the
idb-good
branch
3 times, most recently
from
8997999
to
5ce4047
Compare
|
interfaces added to Window need to be updated in the all-window-properties.txt expectation file: |
ADKaster
reviewed
Nov 4, 2024
Userland/Libraries/LibWeb/IndexedDB/Internal/ConnectionQueueHandler.h
Outdated
Show resolved
Hide resolved
stelar7
force-pushed
the
idb-good
branch
2 times, most recently
from
d54598a
to
00c87fe
Compare
ADKaster
reviewed
Nov 5, 2024
shannonbooth
reviewed
Nov 5, 2024
shannonbooth
reviewed
Nov 5, 2024
Userland/Libraries/LibWeb/IndexedDB/Internal/ConnectionQueueHandler.h
Outdated
Show resolved
Hide resolved
stelar7
force-pushed
the
idb-good
branch
8 times, most recently
from
62789d9
to
1b4dbde
Compare
ADKaster
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now passes 19/29 tests on https://wpt.live/IndexedDB/idbfactory_open.any.html