LibCore: Port Directory to Windows #2188
Open
+58
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
stasoid
force-pushed
the
dir
branch
4 times, most recently
from
dd358e5
to
0148baf
Compare
size >> 31 >> 1 is used instead of size >> 32 to support 32-bit Windows (size_t is 32 bit there, and you cannot shift 32-bit value by 32 bits on x86) This is equivalent to sizeof(size) == 4 ? 0 : size >> 32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires #1918.
This PR is ready for review, but must be rebased before merging. First 3 commits belong to #1918.Update: rebased.NOTE: The only methods of Directory that are used are create (static), is_valid_directory (static), chown and path, also adopt_fd and is_valid_directory are used internally.
The most used method is create, and it is always called with Directory::CreateDirectories::Yes.
Directory::is_valid_directory is called externally only from Web::ResourceLoader::load.
Directory::chown is called only from SessionManagement::create_session_temporary_directory_if_needed.
Directory::path is called only from ConfigFile::open_for_lib and other ConfigFile methods (indirectly through Formatter<Directory>::format).
Among these, only chown uses m_directory_fd. As chown is not implemented on Windows, m_directory_fd is essentially not used. I implemented directory support in System::open only to satisfy internal Directory checks. Without it Directory::create creates the actual directory, but returns an error.