Meta: Add ffmpeg to vcpkg dependencies #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADKaster
force-pushed
the
add-fontconfig
branch
from
238545f
to
ff050a0
Compare
|
Should probably also remove ffmpeg from the build instructions if it is no longer needed as a system dependency |
This should prevent extra calls to find_package() from causing issues.
The dynamic shared lib build of skia doesn't seem to actually express any dependencies in its DT_NEEDED section, so we need to force-load fontconfig into the dependencies of the skia target to avoid runtime linker errors.
Now that we are using shared libraries, it is possible to add into our vcpkg dependencies without worrying about LGPL
ADKaster
force-pushed
the
add-fontconfig
branch
from
ff050a0
to
d807f2b
Compare
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are using shared libraries, it is possible to add
into our vcpkg dependencies without worrying about LGPL.
And some assorted vcpkg + CMake cleanup.
Replacement for #291